feat(web-server): include html files as <link rel="import"> #882

Merged
merged 1 commit into from Jan 30, 2014

Conversation

Projects
None yet
4 participants
@morethanreal

Addresses #828.

@nfroidure

This comment has been minimized.

Show comment Hide comment
@nfroidure

nfroidure Jan 9, 2014

👍

👍

@hppycoder

This comment has been minimized.

Show comment Hide comment
@hppycoder

hppycoder Jan 20, 2014

The issue I see with this is that the HTML5 spec isn't close to finalized, so we might be jumping the gun. That being said even if it was finalized this wouldn't solve the spec as it allows HTML, JS, and CSS. Yours would only take into consideration the HTML side, not the JS side of things. I would suggest adding in JS and test with that as well so it covers what's part of the current spec (as written today).

Spec:
http://w3c.github.io/webcomponents/spec/imports/

HTML5Rocks article:
http://www.html5rocks.com/en/tutorials/webcomponents/imports/

The issue I see with this is that the HTML5 spec isn't close to finalized, so we might be jumping the gun. That being said even if it was finalized this wouldn't solve the spec as it allows HTML, JS, and CSS. Yours would only take into consideration the HTML side, not the JS side of things. I would suggest adding in JS and test with that as well so it covers what's part of the current spec (as written today).

Spec:
http://w3c.github.io/webcomponents/spec/imports/

HTML5Rocks article:
http://www.html5rocks.com/en/tutorials/webcomponents/imports/

@morethanreal

This comment has been minimized.

Show comment Hide comment
@morethanreal

morethanreal Jan 21, 2014

This patch intends to address the problem of including HTML in karma tests which is impossible today without using html2js. There are already standard mechanisms to include CSS and JS that karma can continue using.

This patch intends to address the problem of including HTML in karma tests which is impossible today without using html2js. There are already standard mechanisms to include CSS and JS that karma can continue using.

vojtajina added a commit that referenced this pull request Jan 30, 2014

Merge pull request #882 from morethanreal/feat-htmlimports
feat(web-server): include html files as <link rel="import">

@vojtajina vojtajina merged commit 203a396 into karma-runner:master Jan 30, 2014

@vojtajina

This comment has been minimized.

Show comment Hide comment
@vojtajina

vojtajina Jan 30, 2014

Contributor

@morethanreal Thanks!

If html2js or ng-html2js preprocessor is used, the served path is changed to *.html.js, so this change does not affect that case.

Contributor

vojtajina commented Jan 30, 2014

@morethanreal Thanks!

If html2js or ng-html2js preprocessor is used, the served path is changed to *.html.js, so this change does not affect that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment