Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

fix(config): allow CoffeeScript 1.7 to be used #903

Merged
merged 1 commit into from

2 participants

@eddiemonge

CoffeeScript 1.7 requires a register call to be made. This change is still backwards compatible with older versions of CS because the needed part, the require, is still done. The register function fails but it is wrapped in a try catch block so it fails silently.

lib/config.js
@@ -15,7 +17,9 @@ try {
require('LiveScript');
} catch (e) {}
-var Pattern = function(pattern, served, included, watched) {

Revert this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@eddiemonge eddiemonge fix(config): allow CoffeeScript 1.7 to be used
CoffeeScript 1.7 requires a register call to be made. This change is still backwards compatible with older versions of CS because the needed part, the require, is still done. The register function fails but it is wrapped in a try catch block so it fails silently.
a1583de
@eddiemonge

@vojtajina I dont even know what that was or how it got there.

@vojtajina vojtajina merged commit cee7aa8 into karma-runner:master
@eddiemonge eddiemonge deleted the eddiemonge:patch-1 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 31, 2014
  1. @eddiemonge

    fix(config): allow CoffeeScript 1.7 to be used

    eddiemonge authored
    CoffeeScript 1.7 requires a register call to be made. This change is still backwards compatible with older versions of CS because the needed part, the require, is still done. The register function fails but it is wrapped in a try catch block so it fails silently.
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 1 deletion.
  1. +3 −1 lib/config.js
View
4 lib/config.js
@@ -7,7 +7,9 @@ var constant = require('./constants');
// Coffee is required here to enable config files written in coffee-script.
// It's not directly used in this file.
-require('coffee-script');
+try {
+ require('coffee-script').register();
+} catch (e) {}
// LiveScript is required here to enable config files written in LiveScript.
// It's not directly used in this file.
Something went wrong with that request. Please try again.