New Factory global flags merge function #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/L
helen-frank
changed the title
helen-frank
force-pushed
the
feature/NewFactoryMerge
branch
from
83ca2e2
to
311ee84
Compare
karmada-bot
added
size/M
jwcesign
reviewed
Oct 26, 2022
|
Other lgtm |
lonelyCZ
reviewed
Oct 28, 2022
helen-frank
force-pushed
the
feature/NewFactoryMerge
branch
from
311ee84
to
0f68cdd
Compare
helen-frank
requested review from
lonelyCZ
and removed request for
carlory and
prodanlabs
|
/retest |
helen-frank
force-pushed
the
feature/NewFactoryMerge
branch
from
0f68cdd
to
f13a9f4
Compare
|
/cc @lonelyCZ |
lonelyCZ
reviewed
Nov 7, 2022
helen-frank
force-pushed
the
feature/NewFactoryMerge
branch
from
f13a9f4
to
d91bb99
Compare
karmada-bot
added
size/L
helen-frank
force-pushed
the
feature/NewFactoryMerge
branch
2 times, most recently
from
5845831
to
1c5ffc3
Compare
|
/retest |
helen-frank
force-pushed
the
feature/NewFactoryMerge
branch
from
1c5ffc3
to
5574103
Compare
lonelyCZ
reviewed
Nov 8, 2022
helen-frank
force-pushed
the
feature/NewFactoryMerge
branch
from
5574103
to
cca44f6
Compare
|
I just tested it, and it worked fine in my env. Hi, @RainbowMango , please help to retrigger the workflows. |
|
PTAL /cc @carlory |
helen-frank
force-pushed
the
feature/NewFactoryMerge
branch
from
cca44f6
to
6d45bfe
Compare
lonelyCZ
reviewed
Nov 9, 2022
pkg/karmadactl/promote.go
Outdated
| @@ -85,8 +86,8 @@ func NewCmdPromote(f util.Factory, parentCommand string) *cobra.Command { | |||
| flag := cmd.Flags() | |||
| opts.AddFlags(flag) | |||
|
|
|||
| flag.StringVar(defaultConfigFlags.KubeConfig, "kubeconfig", *defaultConfigFlags.KubeConfig, "Path to the kubeconfig file to use for CLI requests.") | |||
| flag.StringVar(defaultConfigFlags.Context, "karmada-context", *defaultConfigFlags.Context, "The name of the kubeconfig context to use") | |||
| flag.StringVar(options.DefaultConfigFlags.KubeConfig, "kubeconfig", *options.DefaultConfigFlags.KubeConfig, "Path to the kubeconfig file to use for CLI requests.") | |||
There was a problem hiding this comment.
Why not options.AddKubeConfigFlags()?
There was a problem hiding this comment.
Sorry for the omission, now it has been replaced.
helen-frank
force-pushed
the
feature/NewFactoryMerge
branch
2 times, most recently
from
601ddca
to
1a19c52
Compare
karmada-bot
added
the
do-not-merge/contains-merge-commits
Signed-off-by: helen <haitao.zhang@daocloud.io>
helen-frank
force-pushed
the
feature/NewFactoryMerge
branch
from
531a5af
to
3e77449
Compare
karmada-bot
removed
the
do-not-merge/contains-merge-commits
|
Please take a look~ /cc @carlory |
|
It works fine in my env. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lonelyCZ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
|
Change the label to the correct one. |
karmada-bot
added
kind/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
These code comes multiple times, we may extract them as one function.
Which issue(s) this PR fixes:
Fixes #
Port #2611
Special notes for your reviewer:
Does this PR introduce a user-facing change?: