Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Using `#define_method` for fewer surprises #3

Merged
merged 2 commits into from May 14, 2012

Conversation

Projects
None yet
3 participants
Contributor

jneen commented May 11, 2012

Hi there!

This patch uses #define_method under the covers, so that actions are inheritable as methods. It's possible that it performs faster, but honestly I just like the way the code looks a little better :). Up to you.

Cheers,
--Jay

Contributor

statianzo commented May 11, 2012

why not just require defining a method named "action"? Using "def" isn't that painful and would keep it looking like regular ruby.

Contributor

jneen commented May 11, 2012

Good idea - it's possible to support both, I think.

karmajunkie added a commit that referenced this pull request May 14, 2012

Merge pull request #3 from jayferd/master
Using `#define_method` for fewer surprises

@karmajunkie karmajunkie merged commit 20dde0b into karmajunkie:master May 14, 2012

@statianzo statianzo referenced this pull request Jun 11, 2012

Closed

why the DSL? #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment