New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master ticket: Messages #35

Closed
karmatosed opened this Issue Jan 19, 2014 · 20 comments

Comments

Projects
None yet
4 participants
@karmatosed
Owner

karmatosed commented Jan 19, 2014

This wireframe is for the message template.

messages

@karmatosed

This comment has been minimized.

Owner

karmatosed commented Jan 19, 2014

The current status is this:

2014-01-19 at 14 16

@karmatosed

This comment has been minimized.

Owner

karmatosed commented Feb 9, 2014

@hnla: I'm going to suggest you take this on during the sprint. Please say if you are unable to due to time The deadline for this would be the 20th February.

@karmatosed

This comment has been minimized.

Owner

karmatosed commented Feb 9, 2014

@hnla: I see your active so assume you have time to do this by the 20th?

@trishasalas

This comment has been minimized.

trishasalas commented Feb 12, 2014

@hnla, would love to help with this during sprint if you have the need. I can pick up whatever pieces you like.

@hnla

This comment has been minimized.

Collaborator

hnla commented Feb 13, 2014

@trishasalas Love you to help out, you probably have a better understanding of what's required, given your initial work on this; perhaps you could review the current state of the templates, note what works, what doesn't and generally issues you see, then when it functions as necessary we can then look at visually styling it as close to wireframe impression as possible.

@hnla

This comment has been minimized.

Collaborator

hnla commented Feb 13, 2014

@karmatosed Can we remove comment https://github.com/karmatosed/buddypress-templates/issue_comments/32709277 as this is no longer accurate after the bp_nav_menus() and styles were reverted, for the moment it's not a 'current' view.

@trishasalas

This comment has been minimized.

trishasalas commented Feb 21, 2014

@hnla forgive my delay in replying, I have taken a first look and have some ideas to get the functionality we need. I hope to spend some concentrated time this weekend on this and will report back to that end on Monday.

@karmatosed

This comment has been minimized.

Owner

karmatosed commented Feb 23, 2014

I am not going to be in this week's meeting but I would suggest that @hnla and you @trishasalas take that time to discuss this ticket. We need to know if this is feasable for those involved, if they have not had the time yet in the sprint when will they? We can't let things roll on without action a sprint has passed and this is still not done.

I would suggest if there is no movement on this during this week and nothing completed within a week of today then we need to not do this improvement. A shame but if people are unable to do in 4 weeks they are unable to do in the rest of the time left until beta (only a few weeks).

I'm not going to make a judgement, it's up to you both as something you are involved in. I am disappointed we've gone through the sprint with no action on this but sometimes things happen.

What we do need though is follow throughs. If you don't have time that is totally fine, but if you commit you need to ensure we get there.

Now there may be things causing and stalling delay in development. If this is the case bring those up during the devchat. I will note what I am suggesting here in my update on bpdevel.

@trishasalas

This comment has been minimized.

trishasalas commented Feb 24, 2014

I did have a chance to look at this and test some things. I talked to Paul about some of the code issues via Skype. I have made progress and I think a decision can be made Wednesday regarding an approach going forward as well as the feasibility of the intended method.

Yes, things happen and life is not always on schedule with code. That said, I commented in this issue that I would be working on this during the weekend and I have done that.

I will be commenting on this ticket https://buddypress.trac.wordpress.org/ticket/5176 sometime Monday evening US Central time to recap the conversation that Paul and I had. This will give me time to finalize what I am working on and at least publish my branch for you to view. The code is 'all kinds of wrong' at the moment due to development bits and I hope to have most of that cleaned up before I publish.

@hnla

This comment has been minimized.

Collaborator

hnla commented Feb 24, 2014

An explanation or discussion to decide how wireframe works to show all the messages screen views would be useful, boone requested that on the trac ticket and I've mentioned it. The single wireframe view in what is a series of dynamic screens could really do with a simple list views e.g

  • Initial screen left column all messages loop link & avatar only, right screen last message received excerpt.
  • single thread view left col thread responses, right col ...

I'm still somewhat confused as to what we are working towards.

@trishasalas perhaps we can link up over skype between now and wednesday, chat over what you have thus far and how you see this working - time permitting?

@trishasalas

This comment has been minimized.

trishasalas commented Feb 24, 2014

I concur on additional wireframes, it's anybody's guess without them.

@hnla I would like very much to chat some before Wednesday, what does your schedule look like? The earliest I can be available would be 4pm your time (taking into account the 6 hour time difference from US Central)

@hnla

This comment has been minimized.

Collaborator

hnla commented Feb 24, 2014

@trishasalas perhaps Tues 6pm UTC ?

@karmatosed

This comment has been minimized.

Owner

karmatosed commented Mar 2, 2014

@hnla and @trishasalas : I notice some work has been done but this is not complete as of today (Sunday 2nd March). I am willing to allow work to continue until Wednesday morning but all work needs to be done by then. If you need assistance on things please respond to the bpdevel post as I have asked you to. Otherwise, we will have to remove the messages work done and add in a minimal styling. We can't wait beyond Wednesday morning. There has to be some cut off we stick to.

@boonebgorges

This comment has been minimized.

Collaborator

boonebgorges commented Mar 4, 2014

Hi everyone. I have attempted to make some sense of the messages situation. https://github.com/karmatosed/buddypress-templates/tree/messages

From my understanding of the wireframes, there is a persistent left-hand sidebar containing a list of all messages. Instead of hardcoding this into every messages template, I've broken it out into the messages.php wrapper. Then I applied some styling to get the two-paned effect.

The other key change that this suggests is that we no longer need to have a messages-loop.php template. The 'inbox' and 'sentbox' views look just like the 'single' views, except instead of specifying a thread, we just take the most recent one. I put a hack into the messages.php router to make this work; if we agree that it's the way to go, we'll need a fix in BuddyPress. If we do go this route, it might actually make sense to eliminate the 'inbox' and 'sentbox' views altogether from the router - there's no need for these URLs. Clicking Messages would simply lead you to members/boone/messages/view/5 (where 5 is the most recent message). Again, this would be a core change.

For now, I would ditch the Javascript pane-switching. This can be added later on.

If we go with this method, we'll also need some logic for highlighting the current thread on the left-hand menu. This will probably also take a core patch (a new template tag, maybe). Feel free to submit a patch or make an enhancement request on Trac if you need it.

@trishasalas

This comment has been minimized.

trishasalas commented Mar 4, 2014

Thank you for doing this @boonebgorges, this is very similar to what @hnla did in the beginning. Along with what I've done it seems to be very close to the wireframe. I'm not sure I can get the needed patches done by Wednesday. It's up to @karmatosed now how to proceed.

@karmatosed

This comment has been minimized.

Owner

karmatosed commented Mar 5, 2014

I'm not sure we're quite there yet and how long it will take us to get there. I have just played with both branches and there are obvious issues.

If you are willing to do a patch in 24hours that gets it 100% functional, @trishasalas then I'd be ok with that by the end of today. My concern is when I see a day ago @boonebgorges do some awesome work and we're nearly a day again and at the deadline with nothing more than a not sure. Yes, we all have commitments but we need to be real about what we take on board to do in the time. Saying you aren't sure can get patches in I'm afraid doesn't give me much to go on. What are the patches? What is needed? I need to know and we need to have exacts so we can judge accurately.

I'm willing to talk in the dev chat but we have to be precise about our conversations. I'd need answers for the following:

  • What exact tasks including exact time breakdowns are needed? We need one sentence exacts to assign and take action.
  • What exact info and/or help is needed. Who from and exactly what. We need one sentence exacts to assign and take action.

The key is if you don't know what is needed then nobody else can be expected to. Lets get a day focus and please can you @hnla and @trishasalas be in dev chat today at 8pm UTC.

@trishasalas

This comment has been minimized.

trishasalas commented Mar 5, 2014

I understand your concern. I say 'not sure' because that is the truth. I don't know core well enough to say anything with certainty, my availability is waning a well.

If you need an absolute statement, it will be that I've done all I can do and will not have a patch in 24 hours.

As far as dev chat goes, It's possible that I can make it but a previous appointment may not allow for it. I won't know until that time. If I do get there in time I have another meeting at 8:30 pm UTC so will only be available for half an hour.

With @boonebgorges suggesting what appears to be 3 core patches I think it's fair to say that the messaging wireframe was more difficult than anticipated.

@hnla

This comment has been minimized.

Collaborator

hnla commented Mar 5, 2014

@boonebgorges yep you have essentially done pretty much the same as the version I had up a while back, we approached things from a slightly different angle as I got the last message id from a diff quarter along the lines we discussed briefly but essentially we arrive at exactly the same view left column, that work I sacrificed in favour of a mix of mine and Trish's that actually arrived at a closer approximation of the wireframes - both now in evidence given the new branch. Certainly though we have enough code between those to provide the working model and if we go with your take on things we can probably work the JS Trish did into things and the headings and other detail is relatively trivial and provided as working examples in 'master'.

As for patches, I'm not sure what we do need perhaps Tammie you might like to actually suggest something based on what you see or even just bullet those 'issues' you see in both? I guess one required is a means of fetching the message thread based on last or most recent date, I did this simply by running a loop and breaking it after the first iteration which gave me the thread id to pass into messages single view called in to the main screen action=inbox then ran an if/else to remove that arg if action = 'view'

@boonebgorges do some awesome work

Yes I appreciate the help Boone always offers across so many aspects of BP, the hyperbole I appreciate a little less ;) Given that it isn't a markedly different approach from that which I took and essentially arrives at the same rendered views :)

The core patches whatever they may need to be will not likely get done in the timeframe you are expecting I certainly can't devote undivided time to this in preference to real world issues and attendance to work, however once determined exactly what they actually are I doubt they are massively complex, but Boone's a better judge of that, one aspect would be re-fining the action router to remove the inbox/sentbox views which, as Boone says, are likely no longer required and I would agree on that; all actions suggest they are handled on one screen now, but how/where is the 'router' adjusted? In core itself would suggest a backpat issue for older installs?

Tammie at the end of the day it's your decision whether you want to simply go with the existing messages screens and just style if you have deadlines or accept that to get these aspects sorted will take a few more days, make a judgment call based on whether you think what we have and are seeing is worth the time to get finished or whether we throw that work to the wind, do we like this notion of single screen views even at the stage they are? If we do like them there's nothing stopping you styling them if we understand that the required patches won't necessarily change the rendered view or markup but more replace a hacked approach with something more reliable but which is backend / mid-tier functionality at the ens of the day.

@boonebgorges

This comment has been minimized.

Collaborator

boonebgorges commented Mar 5, 2014

Re: core patches. There are a number that I have suggested, but @hnla is correct that changes to the router will be the most significant. To be honest, I haven't thought much about how it would work given backward compatibility issues, and it definitely can't be done in the next few days. That said, I don't think you should nix the approach based merely on this quibble. It can be worked around for now with a redirect or simply by ignoring the sentbox/inbox views.

@karmatosed

This comment has been minimized.

Owner

karmatosed commented Mar 5, 2014

I am more than happy for a work around but what we need (dons project management hat on) is time frames and exacts. If we go another day, 2, 3, 5 ... you see the picture? What I want is to not be the judgement or axe falling, but bring this into perspective of how long we've had and how long we don't have left.

Perhaps @hnla you can work out the time frame and come to today's dev chat with that? Or come with questions to get to that time frame? I would love that.

@karmatosed karmatosed closed this Mar 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment