Implement "Update Mapping" feature #490

Closed
karmi opened this Issue Oct 23, 2012 · 2 comments

Comments

Projects
None yet
2 participants
Owner

karmi commented Oct 23, 2012

So far, Tire can only create or retrieve mapping for an index or model.

An "update mapping" feature should be implemented:

  • Tire::Index#update_mapping should be the low level API/DSL method to handle the feature.
  • The method should handle response errors consistently as all other methods
  • The method should handle response error due to conflicts -- at present, probably just returning false
  • A bang format of the method should be added, which would re-raise any exception (eg. due to conflicts)
  • The method should take options such as ignore_conflicts
  • In the ActiveModel integration, the create_elasticsearch_index method should possibly display a diff of mappings in the error response
Contributor

cjbottaro commented Nov 15, 2012

Here's the pull request... karmi#520

@karmi karmi added a commit that referenced this issue Mar 2, 2013

@karmi karmi Refactored the "Put Mapping" API support
* Cleaned up and simplified code
* Made the return values more compatible with the rest of the API (return `false` for failures, users should check `index.response`)
* Removed `put_mapping!`
* Amended, completed and polished tests
* Updated documentation

Related: #194, #490, #520, #645
8fc5060
Owner

karmi commented Mar 2, 2013

Closed by 8fc5060.

karmi closed this Mar 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment