Implement put mapping API. #194

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

http://www.elasticsearch.org/guide/reference/api/admin-indices-put-mapping.html

The mapping for all types can be set in the index creation request, but
the mapping for a single type must be updated per put mapping request.

Implement put mapping API.
http://www.elasticsearch.org/guide/reference/api/admin-indices-put-mapping.html

The mapping for all types can be set in the index creation request, but
the mapping for a single type must be updated per put mapping request.
Owner

karmi commented Mar 1, 2012

Hello Dylan, thanks, sorry for such embarrasing delay.

I hate to be the asshole who asks for more tests all the time, but I think an integration test would be warranted?

Also what about mapping conflicts? What about the ignore_conflicts option?

jfredett commented Apr 2, 2012

Pretty sure this would fix index creation w/ bonsai (with a little bit of supporting code) -- I'll see if I can write up some integration tests when I get it all working w/ bonsai.

Open source at work!

Contributor

nz commented Aug 31, 2012

+1; this is relevant to my interests. Updating mapping at the index level won't be an issue with Bonsai for much longer, but it always helps to be specific.

@jfredett feel free to drop me a line if you need any support for this stuff on our end over at Bonsai

Owner

karmi commented Oct 23, 2012

@dylanahsmith Let's close this until we have a more complete iplementation with handling or ignoring conflicts, displaying diffs, etc etc?

@karmi karmi referenced this pull request Oct 23, 2012

Closed

Support for PUT mappings #358

karmi added a commit that referenced this pull request Mar 2, 2013

Refactored the "Put Mapping" API support
* Cleaned up and simplified code
* Made the return values more compatible with the rest of the API (return `false` for failures, users should check `index.response`)
* Removed `put_mapping!`
* Amended, completed and polished tests
* Updated documentation

Related: #194, #490, #520, #645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment