Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixing elapsed time presentation on import task #480

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

The time was being shown in a wrong way when the elapsed time is a float number.

@karmi karmi closed this in 6fef487 Oct 16, 2012

Owner

karmi commented Oct 16, 2012

Hi, thanks for looking into that so thoroughly! I consider the Rake task just a utility method, though, and don't think we should add some Utils namespace just for that...

Hi,
I moved the code from tasks.rb to utils.rb to be easier test it.
If you want I can apply the fix on tasks.rb only, just will stay without tests.
Can I do that? The fix is simple but a good presentation be part of a good software.

Regards,
Wandenberg

Owner

karmi commented Oct 17, 2012

Hi, you're absolutely right it should have been fixed. I just fixed the method in tasks.rb, see 6fef487.

While the import Rake task is very useful, it's not a end-all solution and people should be more then ready to write their own feeder scripts; it's very, very convenient and easy to do so in Ruby. The Rake task is a mere convenience for simple cases and a help for beginners.

NOX73 added a commit to NOX73/tire that referenced this pull request Oct 23, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment