Put/Delete mapping support #520

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

cjbottaro commented Nov 15, 2012

My put_mapping branch was branched off of the v0.5.1 tag, but it merges cleanly into master (as of 11:45 am today). I added a couple integration tests and one unit test. All tests pass (both on the branch and on master after merging it).

I just started using ES/Tire and during development/staging to have this feature as we go on changing the mappings, as we go.

reiz commented on e72b409 Dec 11, 2012

Nice. How can I use PUT for a mapping to an index which is already existing? I couldn't find anything in the docu.

reiz commented Dec 11, 2012

An example in the documentation would be useful. I need to know how I can send a mapping via PUT to an existing empty index.

This is an issue for me right now. There is one ES SaaS provider I found, which is creating the index for me. And I am not allowed to delete or overwrite it. I am forced to send my mappings via a PUT to an existing index. Right now Tire is not usable for this task.

I appreciate any kind of feedback.

@karmi karmi closed this in 79ad6f0 Mar 2, 2013

karmi added a commit that referenced this pull request Mar 2, 2013

Refactored the "Put Mapping" API support
* Cleaned up and simplified code
* Made the return values more compatible with the rest of the API (return `false` for failures, users should check `index.response`)
* Removed `put_mapping!`
* Amended, completed and polished tests
* Updated documentation

Related: #194, #490, #520, #645

karmi added a commit that referenced this pull request Mar 2, 2013

karmi added a commit that referenced this pull request Mar 2, 2013

Owner

karmi commented Mar 2, 2013

Finally found time to evaluate and refactor the patch, sorry for the delay! Merged & pushed.

@karmi karmi referenced this pull request Mar 2, 2013

Closed

updating existing mapping #645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment