Pooled curb v1 #713

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

brupm commented Apr 24, 2013

  • Uses https://github.com/jugend/common-pool to allow for high-performance HTTP requests for a multi-threaded environment.
  • Properly handles Curl::Err::MultiBadEasyHandle
  • I will write tests if you think there's validity in this PR.
Owner

karmi commented Apr 24, 2013

Hi, great! Can you please squash the commits into one and also remove the dependency from the gemspec?

Contributor

brupm commented Apr 24, 2013

@karmi all done. The dependency appears to be required, otherwise all will not boot. @karmi Am I missing something?

@brupm brupm Pooled curb client using common_pool lib to prevent "Curl::Err::Multi…
…BadEasyHandle" when using in a multithreaded environment.
0b1e17d
Owner

karmi commented Apr 25, 2013

The dependency appears to be required, otherwise all will not boot

It's the same thing as with eg. the Faraday client -- you need to require the dependency externally, eg. in an application initializer, etc. On a second thought, can you please move the pull request from here to tire-contrib?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment