Pooled curb client using common_pool lib to prevent "Curl::Err::MultiBadEasyHandle" when using in a multithreaded environment. #18

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

brupm commented Apr 25, 2013

  • Uses https://github.com/jugend/common-pool to allow for high-performance HTTP requests for a multi-threaded environment.
  • Properly handles Curl::Err::MultiBadEasyHandle
  • I will write tests if you think there's validity in this PR.

@brupm brupm referenced this pull request in karmi/retire Apr 25, 2013

Closed

Pooled curb v1 #713

Owner

karmi commented Apr 26, 2013

@brupm Cool, I don't think tests are needed, but could you add a short explanation and example as a comment in the file header? A la https://github.com/karmi/tire/blob/master/lib/tire/http/clients/faraday.rb.

Pooled curb client using common_pool lib to prevent "Curl::Err::Multi…
…BadEasyHandle" when using in a multithreaded environment.
Contributor

brupm commented Apr 26, 2013

Should be good now, thanks @karmi. I have been using this in production for over a day now, no more Curl::Err::MultiBadEasyHandle errors, no noticeable speed difference either.

@karmi karmi closed this in 668cb37 Apr 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment