New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stricter UTF8 validation #17

Merged
merged 1 commit into from Mar 21, 2018

Conversation

Projects
None yet
2 participants
@paultcochrane
Contributor

paultcochrane commented Mar 20, 2018

It's currently considered best practice to use 'encoding(UTF-8)' instead
of 'utf8' when reading and writing files, hence this change.

Use stricter UTF8 validation
It's currently considered best practice to use 'encoding(UTF-8)' instead
of 'utf8' when reading and writing files, hence this change.
@karpet

This comment has been minimized.

Owner

karpet commented Mar 21, 2018

Failure due just to installing prereqs on one version (maybe a timeout?) - ok to merge anyway.

@karpet karpet merged commit cc0e783 into karpet:master Mar 21, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@paultcochrane

This comment has been minimized.

Contributor

paultcochrane commented Mar 21, 2018

Hrm, interesting. My Travis build ran successfully, otherwise I wouldn't have submitted the PR. I have noticed that some prereqs don't always build and test successfully, so hopefully that's what happened in this case.

@paultcochrane

This comment has been minimized.

Contributor

paultcochrane commented Mar 21, 2018

BTW: I noticed that http://swish-e.org doesn't answer anymore; is there another site one could use for the spider tests?

@paultcochrane paultcochrane deleted the paultcochrane:pr/use-encoding-for-ut8 branch Mar 21, 2018

@karpet

This comment has been minimized.

Owner

karpet commented Mar 21, 2018

Good catch - I have updated the test to point at dezi.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment