Use stricter UTF8 validation #17
Merged
Conversation
It's currently considered best practice to use 'encoding(UTF-8)' instead of 'utf8' when reading and writing files, hence this change.
|
Failure due just to installing prereqs on one version (maybe a timeout?) - ok to merge anyway. |
|
Hrm, interesting. My Travis build ran successfully, otherwise I wouldn't have submitted the PR. I have noticed that some prereqs don't always build and test successfully, so hopefully that's what happened in this case. |
|
BTW: I noticed that http://swish-e.org doesn't answer anymore; is there another site one could use for the spider tests? |
|
Good catch - I have updated the test to point at dezi.org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
It's currently considered best practice to use 'encoding(UTF-8)' instead
of 'utf8' when reading and writing files, hence this change.