New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing prereqs #18

Merged
merged 2 commits into from Mar 24, 2018

Conversation

Projects
None yet
2 participants
@paultcochrane
Contributor

paultcochrane commented Mar 24, 2018

CPANTS noticed that Carp, File::Spec and Digest::MD5 weren't mentioned as part of the prereqs. The first commit in this PR should fix that issue. The second commit sorts the prereqs alphabetically so that it's a bit easier to find and/or add prereqs.

paultcochrane added some commits Mar 24, 2018

Add missing prereqs to build config
It turns out to be good practice to mention all of the prereqs for a
distribution, even if the modules are part of Perl core.  This issue was
noticed by CPANTS as part of the `prereq_matches_use` kwalitee metric.
Sort prereqs alphabetically
... which makes it a bit easier to what is where and where new prereqs
should be added.
@karpet

This comment has been minimized.

Owner

karpet commented Mar 24, 2018

All 3 modules are (or were, ime) part of the core perl distribution so I've not bothered listing them in any of my modules. But I suppose it doesn't hurt.
Thanks!

@karpet karpet merged commit 017a0db into karpet:master Mar 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@paultcochrane paultcochrane deleted the paultcochrane:pr/add-missing-prereqs branch Mar 24, 2018

@paultcochrane

This comment has been minimized.

Contributor

paultcochrane commented Mar 24, 2018

Yeah, I've always wondered at the utility of specifying core Perl modules in the prereqs list. However, I've seen this more and more that even core modules are being specified, so it looks like it's part of current best practices. My guess is that a core module could become "noncore" at some point in the future, so (like you say) it doesn't hurt to specify them. Thanks for the fast merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment