Usually, when one wants to check for availability of a given module, it is better to use Class::Load than to call use within a string evaluation. Hence the motivation for this pull request. The main thing that I think you should check is the commit I made to replace stringy eval in the spider tests: I altered the existing behaviour slightly in that, if Dezi::Aggregator::Spider is not present, then the tests are skipped. The match for the error message has been left out in the new version of the code. I think this is ok (it wasn't 100% clear to me what the extra match was achieving, other than providing information about which module was required for the spider tests); if this change isn't ok, then I don't have any problems with leaving it out. Alternatively, if you'd like some particular kind of extra functionality here, just let me know and I can update the PR as necessary.
Hrm, that's what I thought, but I tried uninstalling a module used by D::A::S to see if I could trigger the regexp part required for the skip, but the test would die with a compile time error and wasn't simply skipping the tests, so the eval didn't seem to be doing what it was intended to do. Thanks for clearing that one up for me :-)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.