Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mailfiles with variables #22

Merged

Conversation

@paultcochrane
Copy link
Contributor

@paultcochrane paultcochrane commented Mar 24, 2018

Apart from the fact that CPANTS flags the mbox files as being non-portable, it seems cleaner to create such files automatically as part of the tests which create them so that the files don't need to be part of the dist at all. This also allowed for the dist.ini to be simplified somewhat, since the need to specifically include all dotfilles and then add a list of those which one still wanted to exclude from the dist was a bit hacky and was likely to cause maintenance headaches in the future.

Paul Cochrane added 3 commits Mar 24, 2018
This removes the need to have a non-portable file in the distribution
and repository (see the `portable_filenames` CPANTS issue) and makes the
mail tests more self contained.  Also, this can improve packaging since
the `.INBOX` directory no longer needs to exist as part of the package:
this directory and the associated mbox file can simply be created as
part of the test and then removed afterwards.
Similarly to the previous commit, it's easier (and more portable) to
just define the mbox file as a DATA variable than as an actual file in
the repository and thus in the distribution.
This is now possible since the `.INBOX` test directory is no longer in
the repository.
@karpet
Copy link
Owner

@karpet karpet commented Mar 24, 2018

This one's been around for 10 years and this is a much tidier solution. Thank you!

@paultcochrane
Copy link
Contributor Author

@paultcochrane paultcochrane commented Mar 24, 2018

My pleasure! Actually, I really like helping out with such stuff, so it's been fun to have been able to make a contribution. Thanks for merging the patches so quickly! That made it much easier for me to resolve other issues.

@karpet karpet merged commit cf0119f into karpet:master Mar 24, 2018
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants