New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'perl' explicitly as license in metadata #4

Merged
merged 1 commit into from Mar 14, 2018

Conversation

Projects
None yet
2 participants
@paultcochrane
Contributor

paultcochrane commented Mar 13, 2018

The previous value, being a URL, did not conform to the META spec,
making the metadata invalid.

This change also fixes the core CPANTS issue: meta_yml_conforms_to_known_spec.

Hope this helps! If you want anything changed, just let me know and I'll update the PR as appropriate and resubmit.

Use 'perl' explicitly as license in metadata
The previous value, being a URL, did not conform to the META spec,
making the metadata invalid.
@karpet

This comment has been minimized.

Owner

karpet commented Mar 13, 2018

Thanks.
I see that the metadata and README are out of sync. The README says GPL v2, which is probably wrong. The SWISH::3 module is GPL v2 because it compiles against libswish3, but that doesn't extend to libraries that include it.
If you patched README.pod too that would be ideal.

@paultcochrane

This comment has been minimized.

Contributor

paultcochrane commented Mar 13, 2018

Yes I just noticed the inconsistency myself. Other files also mention the GPLv2 explicitly, and since the Artistic License also allows the GPL, maybe everything should be licensed GPLv2? I'll definitely patch the README and update the PR.

@paultcochrane

This comment has been minimized.

Contributor

paultcochrane commented Mar 13, 2018

Oops, and there are files explicitly licensed as per the terms for Perl. Which would you like to have? Once I know, I can update the license sections and submit a PR for that change.

@karpet

This comment has been minimized.

Owner

karpet commented Mar 13, 2018

Yeah, the license stuff is a definite mess.

Let's go Perl. The bulk derives from SWISH::Prog which was Perl license, and there are no XS/C components like SWISH::3 has.

Thank you!

@paultcochrane

This comment has been minimized.

Contributor

paultcochrane commented Mar 13, 2018

No worries :-)

@paultcochrane

This comment has been minimized.

Contributor

paultcochrane commented Mar 13, 2018

Actually, as a completely separate issue, would you like me to migrate the dist to Dist::Zilla? The main reason being that Module::Install is officially deprecated and Dist::Zilla would allow you to create such things as the new META.json file automatically and can potentially do many other things. My Dist::Zilla-foo is still fairly basic, however I could give it a go if you'd like.

@karpet

This comment has been minimized.

Owner

karpet commented Mar 13, 2018

Sure that sounds reasonable - thank you.

@karpet

This comment has been minimized.

Owner

karpet commented Mar 14, 2018

Looks like a search/replace for s/it under the terms of the GPL v2 or later/it under the terms of the Perl Artistic license/g would do it.

@karpet karpet merged commit 6d6456f into karpet:master Mar 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@paultcochrane paultcochrane deleted the paultcochrane:pr/fix-license-metadata branch Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment