/dezi-app

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manifest warnings #9

Merged
merged 2 commits into from Mar 14, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@paultcochrane @karpet
@paultcochrane
Contributor

paultcochrane commented Mar 14, 2018

No description provided.

paultcochrane added some commits Mar 14, 2018

@paultcochrane
Remove superfluous file from MANIFEST 
It looks like this file had been around at the time of MANIFEST
creation, however wasn't part of the repository.  This silences a
warning at Makefile build time that the file is missing from the dist.
fd5b4f1
@paultcochrane
Fix README filename in MANIFEST 
The README has been converted to POD and as such now has a `.pod`
extension.  This change brings the MANIFEST up to date.
e22ac42
@paultcochrane

This comment has been minimized.

Sign in to view
Contributor

paultcochrane commented Mar 14, 2018

Sh*t! It looks like I mistakenly hit Enter before I could give this PR a proper description. Sorry! I noticed that an extra file was mentioned in the MANIFEST and that the README filename needed updating. This PR corrects those two issues.

@paultcochrane paultcochrane changed the title from Pr/fix manifest warnings to Fix manifest warnings Mar 14, 2018

@karpet karpet merged commit d39075e into karpet:master Mar 14, 2018
1 check was pending

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@paultcochrane

This comment has been minimized.

Sign in to view
Contributor

paultcochrane commented Mar 14, 2018

Awesome! Many thanks for merging these patches :-)
@karpet

This comment has been minimized.

Sign in to view
Owner

karpet commented Mar 14, 2018

thank you for taking the time! Are you an actual user of this module, or taking up the perl pull request challenge? or both?
@paultcochrane

This comment has been minimized.

Sign in to view
Contributor

paultcochrane commented Mar 14, 2018

Heh, no worries :-) I'm doing the pull request challenge. Sorry for not making this clear up front; I tend to make the assumption that people don't mind pull requests anyway, so I've stopped mentioning it in my initial PRs.

@paultcochrane paultcochrane deleted the paultcochrane:pr/fix-manifest-warnings branch Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment