New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declaring minimum perl version #4

Merged
merged 1 commit into from Feb 27, 2015

Conversation

Projects
None yet
2 participants
@garu
Contributor

garu commented Feb 27, 2015

Hi! Me again :)

Template::Plugin::Autoformat passes all core Kwalitee metrics which is pretty cool. In fact, the only extra metric missing is that it doesn't declare the minimum perl version to run. According to perlver, that version is 5.6.0:

$ perlver .

   ----------------------------------------------------------------
 | file                              | explicit | syntax | external |
 | ---------------------------------------------------------------- |
 | Makefile.PL                       | ~        | v5.6.0 | n/a      |
 | lib/Template/Plugin/Autoformat.pm | ~        | v5.6.0 | n/a      |
 | t/001-autoformat.t                | ~        | v5.6.0 | n/a      |
 | t/autoform.t                      | ~        | v5.6.0 | n/a      |
 | ---------------------------------------------------------------- |
 | Minimum explicit version : ~                                     |
 | Minimum syntax version   : v5.6.0                                |
 | Minimum version of perl  : v5.6.0                                |
   ----------------------------------------------------------------

So I went ahead and added it to the Makefile.PL. Note that it already has a PASS report on CPAN Testers for 5.6.2, so I think we're ok on 5.6. Hope it helps!

Cheers

karpet added a commit that referenced this pull request Feb 27, 2015

@karpet karpet merged commit f2b9b32 into karpet:master Feb 27, 2015

@garu garu deleted the garu:garu/min_perl_version branch Feb 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment