Skip to content

Commit 4f26746

Browse files
authored
Fixes #667: UPS ReferenceNumber changes
* UPS: Add additional package level ReferenceNumber to UPS API request * UPS: Remove optional keys from shipment level ReferenceNumber field which were incorrect or hardcoded anyway
1 parent 0b4c7d1 commit 4f26746

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

  • modules/connectors/ups/karrio/providers/ups/shipment

modules/connectors/ups/karrio/providers/ups/shipment/create.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,8 +291,6 @@ def shipment_request(
291291
MovementReferenceNumber=None,
292292
ReferenceNumber=(
293293
ups.ReferenceNumberType(
294-
BarCodeIndicator=None,
295-
Code=shipper.country_code,
296294
Value=payload.reference,
297295
)
298296
if (country_pair not in ["US/US", "PR/PR"])
@@ -617,6 +615,14 @@ def shipment_request(
617615
Commodity=None,
618616
PackageServiceOptions=None,
619617
UPSPremier=None,
618+
ReferenceNumber=(
619+
ups.ReferenceNumberType(
620+
Value=package.reference_number,
621+
)
622+
if (country_pair not in ["US/US", "PR/PR"])
623+
and any(package.reference_number or "")
624+
else None
625+
),
620626
)
621627
for package in packages
622628
],

0 commit comments

Comments
 (0)