fix: sapient shipment cancellation response parsing

Author: danh91

modules/connectors/sapient/karrio/mappers/sapient/proxy.py

@@ -40,6 +40,7 @@ def cancel_shipment(self, request: lib.Serializable) -> lib.Deserializable[str]:
                 "Authorization": f"Bearer {self.settings.access_token}",
                 "user-agent": "Karrio/1.0",
             },
+            on_ok=lambda _: '{"ok": true}',
             on_error=provider_utils.parse_error_response,
         )
 

modules/connectors/sapient/karrio/providers/sapient/shipment/cancel.py

@@ -39,7 +39,7 @@ def shipment_cancel_request(
             # fmt: off
             {
                 "reason": lib.OptionEnum("Reason"),
-                "shipment_ids": lib.OptionEnum("ShipmentIds"),
+                "shipment_ids": lib.OptionEnum("ShipmentIds", list),
             },
             # fmt: on
         ),
@@ -48,6 +48,7 @@ def shipment_cancel_request(
     # map data to convert karrio model to sapient specific type
     request = dict(
         Status="Cancel",
+        Reason=options.reason.state or "Order Cancelled",
         ShipmentIds=lib.identity(
             options.shipment_ids.state or [payload.shipment_identifier]
         ),

modules/connectors/sapient/karrio/providers/sapient/utils.py

@@ -111,6 +111,11 @@ class ConnectionConfig(lib.Enum):
 
 def parse_error_response(response):
     """Parse the error response from the SAPIENT API."""
+    content = lib.failsafe(lambda: lib.decode(response.read()))
+
+    if any(content or ""):
+        return content
+
     return lib.to_json(
         dict(Errors=[dict(ErrorCode=str(response.code), Message=response.reason)])
     )

modules/connectors/sapient/tests/sapient/test_shipment.py

@@ -302,6 +302,7 @@ def test_parse_cancel_shipment_response(self):
 ShipmentCancelRequest = {
     "ShipmentIds": ["fa3bb603-2687-4b38-ba18-3264208446c6"],
     "Status": "Cancel",
+    "Reason": "Order Cancelled",
 }