chore: debug and consolidate eshipper shipment cancellation with live tests

Author: danh91

modules/connectors/eshipper/karrio/mappers/eshipper/proxy.py

@@ -37,6 +37,7 @@ def create_shipment(self, request: lib.Serializable) -> lib.Deserializable[str]:
         return lib.Deserializable(response, lib.to_dict)
 
     def cancel_shipment(self, request: lib.Serializable) -> lib.Deserializable[str]:
+        print(self.settings.access_token)
         response = lib.request(
             url=f"{self.settings.server_url}/api/v2/ship/cancel",
             data=lib.to_json(request.serialize()),

modules/connectors/eshipper/karrio/providers/eshipper/shipment/cancel.py

@@ -13,7 +13,7 @@ def parse_shipment_cancel_response(
 ) -> typing.Tuple[models.ConfirmationDetails, typing.List[models.Message]]:
     response = _response.deserialize()
     messages = error.parse_error_response(response, settings)
-    success = len(response.get("order")) > 0
+    success = not any(messages)
 
     confirmation = (
         models.ConfirmationDetails(

modules/core/karrio/server/core/dataunits.py

@@ -92,14 +92,15 @@ def _get_generic_carriers():
         ]
 
         extra_carriers = {
-            f"{c.credentials.get('custom_carrier_name') or "generic"}": c.display_name for c in custom_carriers
+            f"{c.credentials.get('custom_carrier_name') or 'generic'}": c.display_name
+            for c in custom_carriers
         }
         system_carriers = {
-            f"{c.credentials.get('custom_carrier_name') or "generic"}": c.display_name
+            f"{c.credentials.get('custom_carrier_name') or 'generic'}": c.display_name
             for c in system_custom_carriers
         }
         extra_services = {
-            f"{c.credentials.get('custom_carrier_name') or "generic"}": {
+            f"{c.credentials.get('custom_carrier_name') or 'generic'}": {
                 s.service_code: s.service_code for s in c.services.all()
             }
             for c in custom_carriers

modules/graph/karrio/server/graph/tests/test_carrier_connections.py

@@ -211,7 +211,6 @@ def test_update_user_connection(self):
                     "customer_number": "2004381_updated",
                     "password": "0bfa9fcb9853d1f51ee57a_updated",
                     "username": "6e93d53968881714_updated",
-                    "language": "en",
                 },
             }
         }