You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Awesome! Only suggestion is to change name from deutschepost to dhl_de, dhl_parcel_de or similar. This API is for DHL Parcel Germany and called DHL Parcel DE Shipping by DHL themselves. Only the service "DHL Warenpost" is handled on the Deutsche Post network (while still being offered as a DHL service) - so deutschepost would be misleading to users.
Awesome! Only suggestion is to change name from deutschepost to dhl_de, dhl_parcel_de or similar. This API is for DHL Parcel Germany and called DHL Parcel DE Shipping by DHL themselves. Only the service "DHL Warenpost" is handled on the Deutsche Post network (while still being offered as a DHL service) - so deutschepost would be misleading to users.
I completely agree 👍🏿. I will hotfix it since it hasn't been released yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carrier integrationPurplship Carrier Integration related issuesepicIssues that require planning and more research
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
danh91
added
carrier integration
deutschepostextension as dpdhl API upgrade