Value calculation slightly off with integral step value #13

Closed
mchubby opened this Issue May 28, 2014 · 3 comments

Projects

None yet

2 participants

@mchubby
mchubby commented May 28, 2014

Hi,
The calculation seems a bit off when using step=1.
See: http://cssdeck.com/labs/bnagqglo

The left part of the first star sets the value to zero, which is akin to clicking the "clear" button.
More generally, clicking the left part of the n-th star yields a value of (n-1).
Is this intended behavior?

@kartik-v
Owner

Yes its kind of intended behavior - since the design has to consider fractional fills as well... and that can correctly happen only if the plugin understands where the user clicks on the star.

Users will more appreciate this with fractional fills (e.g. try setting the step to 0.5 for 5 stars between 0 to 5) and check the experience.

Thus, in order to completely fill a star one has to click towards the right end of the star. The plugin tries its best to round it of to the highest precision based on the step provided. Do you have any other suggestions? I am open for improving this.

EDIT: I am providing a fix for this shortly.

@kartik-v
Owner

This is now resolved with the latest commit 573f4d8.

Precision in calculation has been made more intelligent and will logically react to fill the star when the user clicks on a star (based on the step defined).

@kartik-v kartik-v closed this May 29, 2014
@mchubby
mchubby commented May 29, 2014

Thanks, I believe it works like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment