Fix for bug with PHP date format when convertFormat=true and widget format is not set #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not set Problem: when `DatePicker` is configured with `convertFormat=true`, `format` not specified and `Yii::$app->formatter` specified the date in PHP format (for ex. 'php:Y-m-d'), the DatePicker incorrectly calls convertDateIcuToPhp() on that PHP format. This happens due to the condition `if (isset($this->dateFormat) ... )` being always false, because the `$dateFormat` field does not exist (and never set) in both `InputWidget` and `DatePicker` classes. The local variable `$format` should have been used in the `if` instead.
|
Will review and update on this. |
|
Resolved via latest release update v1.7.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: when
DatePickeris configured withconvertFormat=true,formatnot specified andYii::$app->formatterspecified the date in PHP format (for ex. 'php:Y-m-d'), the DatePicker incorrectly calls convertDateIcuToPhp() on that PHP format.This happens due to the condition
if (isset($this->dateFormat) ... )being always false, because the$dateFormatfield does not exist (and never set) in bothInputWidgetandDatePickerclasses. The local variable$formatshould have been used in theifinstead.