From 26f13f9c89745470c4d02b511e01d5ce17bb41a4 Mon Sep 17 00:00:00 2001
From: Jarle Pedersen <Jarle.Pedersen@geodata.no>
Date: Fri, 18 Sep 2020 10:31:11 +0200
Subject: [PATCH 1/4] read timeOut from app.config

---
 .../SynchController.cs                        | 20 ++++++++++++++++---
 .../Test_Subscriber_NetCore/App.config        |  3 +++
 2 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber.BL/SynchController.cs b/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber.BL/SynchController.cs
index 4d030d34..ce36033b 100644
--- a/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber.BL/SynchController.cs
+++ b/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber.BL/SynchController.cs
@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.ComponentModel;
+using System.Configuration;
 using System.Diagnostics;
 using System.IO;
 using System.Linq;
@@ -40,6 +41,9 @@ public void InitTransactionsSummary()
 
         public TransactionSummary TransactionsSummary;
 
+        private static int _timeout = -1;
+        private int timeout { get { return _timeout == -1 ? GetTimeout() : _timeout; } }
+
         public IBindingList GetCapabilitiesProviderDataset(string url, string UserName, string Password)
         {
             var cdb = new CapabilitiesDataBuilder(url, UserName, Password);
@@ -566,9 +570,7 @@ private void GetStatusForChangelogOnProvider(int datasetId, string changeLogId)
                 var starttid = DateTime.Now;
                 var elapsedTicks = DateTime.Now.Ticks - starttid.Ticks;
 
-                var elapsedSpan = new TimeSpan(elapsedTicks);
-                var timeout = 15;
-                //timeout = 50; // TODO: Fix for Norkart Provider,
+                var elapsedSpan = new TimeSpan(elapsedTicks);                
 
                 while ((changeLogStatus == ChangelogStatusType.queued || changeLogStatus == ChangelogStatusType.working) &&
                        elapsedSpan.Minutes < timeout)
@@ -607,6 +609,18 @@ private void GetStatusForChangelogOnProvider(int datasetId, string changeLogId)
             }
         }
 
+        private static int GetTimeout()
+        {
+            var config = ConfigurationManager.OpenExeConfiguration(ConfigurationUserLevel.PerUserRoamingAndLocal);
+
+            var settings = config.GetSectionGroup("userSettings");
+            var section = settings.Sections["Kartverket.Geosynkronisering.Subscriber.Properties.Subscriber"] as ClientSettingsSection;
+
+            _timeout = int.Parse(section.Settings.Get("TimeOut").Value.ValueXml.InnerText);
+
+            return _timeout;
+        }
+
         private static List<string> ChangeLogMapper(IEnumerable<string> fileList, int datasetId)
         {
             var newFileList = new List<string>();
diff --git a/Kartverket.Geosynkronisering.Subscriber/Test_Subscriber_NetCore/App.config b/Kartverket.Geosynkronisering.Subscriber/Test_Subscriber_NetCore/App.config
index ab439b33..14132cc2 100644
--- a/Kartverket.Geosynkronisering.Subscriber/Test_Subscriber_NetCore/App.config
+++ b/Kartverket.Geosynkronisering.Subscriber/Test_Subscriber_NetCore/App.config
@@ -17,6 +17,9 @@
       <setting name="DefaultServerURL" serializeAs="String">
         <value>https://geosynk.nois.no/tilbyder/</value>
       </setting>
+	<setting name="TimeOut" serializeAs="Int">
+		<value>50</value>
+	</setting>
     </Kartverket.Geosynkronisering.Subscriber.Properties.Subscriber>
   </userSettings>
   <!--<system.serviceModel>

From 8c0039ee1420430cf5e5b2e5b875e633544ec159 Mon Sep 17 00:00:00 2001
From: Jarle Pedersen <Jarle.Pedersen@geodata.no>
Date: Fri, 18 Sep 2020 10:32:30 +0200
Subject: [PATCH 2/4] added timeout to app.config

---
 .../Kartverket.Geosynkronisering.Subscriber/App.config         | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber/App.config b/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber/App.config
index 96e40a71..62f4c08b 100644
--- a/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber/App.config
+++ b/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber/App.config
@@ -44,6 +44,9 @@
       <setting name="DefaultServerURL" serializeAs="String">
         <value>https://geosynk.nois.no/tilbyder/</value>
       </setting>
+	<setting name="TimeOut" serializeAs="Int">
+		<value>50</value>
+	</setting>
     </Kartverket.Geosynkronisering.Subscriber.Properties.Subscriber>
   </userSettings>
   <runtime>

From 93e5105ba73f07fc160930405c6ef8cd3a7ff4bd Mon Sep 17 00:00:00 2001
From: Jarle Pedersen <Jarle.Pedersen@geodata.no>
Date: Fri, 18 Sep 2020 10:53:58 +0200
Subject: [PATCH 3/4] tip user about timeOut-setting use stopWatch use more
 proper exceptiontype

---
 .../SynchController.cs                                | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber.BL/SynchController.cs b/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber.BL/SynchController.cs
index ce36033b..59760ea8 100644
--- a/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber.BL/SynchController.cs
+++ b/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber.BL/SynchController.cs
@@ -567,17 +567,12 @@ private void GetStatusForChangelogOnProvider(int datasetId, string changeLogId)
             {
                 var changeLogStatus = GetChangelogStatusResponse(datasetId, changeLogId);
 
-                var starttid = DateTime.Now;
-                var elapsedTicks = DateTime.Now.Ticks - starttid.Ticks;
-
-                var elapsedSpan = new TimeSpan(elapsedTicks);                
+                var stopWatch = Stopwatch.StartNew();                
 
                 while ((changeLogStatus == ChangelogStatusType.queued || changeLogStatus == ChangelogStatusType.working) &&
-                       elapsedSpan.Minutes < timeout)
+                       stopWatch.Elapsed.TotalMinutes < timeout)
                 {
                     System.Threading.Thread.Sleep(3000);
-                    elapsedTicks = DateTime.Now.Ticks - starttid.Ticks;
-                    elapsedSpan = new TimeSpan(elapsedTicks);
                     changeLogStatus = GetChangelogStatusResponse(datasetId, changeLogId);
                 }
                 if (changeLogStatus == ChangelogStatusType.finished)
@@ -596,7 +591,7 @@ private void GetStatusForChangelogOnProvider(int datasetId, string changeLogId)
                             throw new IOException("Recieved ChangelogStatus == failed from provider");
                         default:
                             Logger.Info("Timeout");
-                            throw new IOException("Timed out waiting for ChangelogStatus == finished from provider");
+                            throw new TimeoutException($"Timed out waiting for ChangelogStatus == finished from provider. Try increasing the TimeOut-value in the .config-file. Current value: {timeout} minutes");
                     }
                 }
             }

From e4fca33526a1d8e076946fb12644423533fff96b Mon Sep 17 00:00:00 2001
From: "NORCONSULTAD\\leg" <lars.eggan@norconsult.com>
Date: Fri, 18 Sep 2020 14:50:14 +0200
Subject: [PATCH 4/4] Fixed settings for Subscriber.

---
 .../App.config                                   | 16 +++++++++++-----
 .../Properties/Subscriber.Designer.cs            | 14 +++++++++++++-
 .../Properties/Subscriber.settings               |  3 +++
 .../Test_Subscriber_NetCore/App.config           |  6 +++---
 4 files changed, 30 insertions(+), 9 deletions(-)

diff --git a/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber/App.config b/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber/App.config
index 62f4c08b..d62ca91e 100644
--- a/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber/App.config
+++ b/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber/App.config
@@ -32,7 +32,8 @@
   <nlog throwExceptions="true" internalLogToConsole="true" xmlns="http://www.nlog-project.org/schemas/NLog.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
     <targets>
       For nlog use TEMP folder, one file for error, one for logging.
-      <target name="errorfile" xsi:type="File" fileName="${tempdir:dir}/Kartverket.Geosynkronisering.Subscriber_Error_${shortdate}.log" layout="${longdate}|${level:uppercase=true}|${logger}|${message}|${exception:format=tostring}|${stacktrace}" /><target name="logfile" xsi:type="File" fileName="${tempdir:dir}/Kartverket.Geosynkronisering.Subscriber_Log_${shortdate}.log" layout="${longdate}|${level:uppercase=true}|${logger}|${message}" /></targets>
+      <target name="errorfile" xsi:type="File" fileName="${tempdir:dir}/Kartverket.Geosynkronisering.Subscriber_Error_${shortdate}.log" layout="${longdate}|${level:uppercase=true}|${logger}|${message}|${exception:format=tostring}|${stacktrace}" /><target name="logfile" xsi:type="File" fileName="${tempdir:dir}/Kartverket.Geosynkronisering.Subscriber_Log_${shortdate}.log" layout="${longdate}|${level:uppercase=true}|${logger}|${message}" />
+    </targets>
     <rules>
       <logger name="*" writeTo="logfile" minlevel="Info" />
       <logger name="*" writeTo="logfile" minlevel="Debug" />
@@ -41,12 +42,15 @@
   </nlog>
   <userSettings>
     <Kartverket.Geosynkronisering.Subscriber.Properties.Subscriber>
+      <setting name="DefaultDatasetId" serializeAs="String">
+        <value>1</value>
+      </setting>
       <setting name="DefaultServerURL" serializeAs="String">
         <value>https://geosynk.nois.no/tilbyder/</value>
       </setting>
-	<setting name="TimeOut" serializeAs="Int">
-		<value>50</value>
-	</setting>
+      <setting name="TimeOut" serializeAs="String">
+        <value>15</value>
+      </setting>
     </Kartverket.Geosynkronisering.Subscriber.Properties.Subscriber>
   </userSettings>
   <runtime>
@@ -87,6 +91,8 @@
     <DbProviderFactories>
       <remove invariant="System.Data.SQLite.EF6" />
       <add name="SQLite Data Provider (Entity Framework 6)" invariant="System.Data.SQLite.EF6" description=".NET Framework Data Provider for SQLite (Entity Framework 6)" type="System.Data.SQLite.EF6.SQLiteProviderFactory, System.Data.SQLite.EF6" />
-    <remove invariant="System.Data.SQLite" /><add name="SQLite Data Provider" invariant="System.Data.SQLite" description=".NET Framework Data Provider for SQLite" type="System.Data.SQLite.SQLiteFactory, System.Data.SQLite" /></DbProviderFactories>
+      <remove invariant="System.Data.SQLite" />
+      <add name="SQLite Data Provider" invariant="System.Data.SQLite" description=".NET Framework Data Provider for SQLite" type="System.Data.SQLite.SQLiteFactory, System.Data.SQLite" />
+    </DbProviderFactories>
   </system.data>
 </configuration>
\ No newline at end of file
diff --git a/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber/Properties/Subscriber.Designer.cs b/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber/Properties/Subscriber.Designer.cs
index 59bfb698..85eb867f 100644
--- a/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber/Properties/Subscriber.Designer.cs
+++ b/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber/Properties/Subscriber.Designer.cs
@@ -12,7 +12,7 @@ namespace Kartverket.Geosynkronisering.Subscriber.Properties {
     
     
     [global::System.Runtime.CompilerServices.CompilerGeneratedAttribute()]
-    [global::System.CodeDom.Compiler.GeneratedCodeAttribute("Microsoft.VisualStudio.Editors.SettingsDesigner.SettingsSingleFileGenerator", "16.4.0.0")]
+    [global::System.CodeDom.Compiler.GeneratedCodeAttribute("Microsoft.VisualStudio.Editors.SettingsDesigner.SettingsSingleFileGenerator", "16.7.0.0")]
     internal sealed partial class Subscriber : global::System.Configuration.ApplicationSettingsBase {
         
         private static Subscriber defaultInstance = ((Subscriber)(global::System.Configuration.ApplicationSettingsBase.Synchronized(new Subscriber())));
@@ -46,5 +46,17 @@ internal sealed partial class Subscriber : global::System.Configuration.Applicat
                 this["DefaultServerURL"] = value;
             }
         }
+        
+        [global::System.Configuration.UserScopedSettingAttribute()]
+        [global::System.Diagnostics.DebuggerNonUserCodeAttribute()]
+        [global::System.Configuration.DefaultSettingValueAttribute("15")]
+        public int TimeOut {
+            get {
+                return ((int)(this["TimeOut"]));
+            }
+            set {
+                this["TimeOut"] = value;
+            }
+        }
     }
 }
diff --git a/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber/Properties/Subscriber.settings b/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber/Properties/Subscriber.settings
index 16f80884..d5f8e69a 100644
--- a/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber/Properties/Subscriber.settings
+++ b/Kartverket.Geosynkronisering.Subscriber/Kartverket.Geosynkronisering.Subscriber/Properties/Subscriber.settings
@@ -8,5 +8,8 @@
     <Setting Name="DefaultServerURL" Type="System.String" Scope="User">
       <Value Profile="(Default)">https://geosynk.nois.no/tilbyder/</Value>
     </Setting>
+    <Setting Name="TimeOut" Type="System.Int32" Scope="User">
+      <Value Profile="(Default)">15</Value>
+    </Setting>
   </Settings>
 </SettingsFile>
\ No newline at end of file
diff --git a/Kartverket.Geosynkronisering.Subscriber/Test_Subscriber_NetCore/App.config b/Kartverket.Geosynkronisering.Subscriber/Test_Subscriber_NetCore/App.config
index 14132cc2..bcc7dede 100644
--- a/Kartverket.Geosynkronisering.Subscriber/Test_Subscriber_NetCore/App.config
+++ b/Kartverket.Geosynkronisering.Subscriber/Test_Subscriber_NetCore/App.config
@@ -17,9 +17,9 @@
       <setting name="DefaultServerURL" serializeAs="String">
         <value>https://geosynk.nois.no/tilbyder/</value>
       </setting>
-	<setting name="TimeOut" serializeAs="Int">
-		<value>50</value>
-	</setting>
+      <setting name="TimeOut" serializeAs="String">
+        <value>15</value>
+      </setting>
     </Kartverket.Geosynkronisering.Subscriber.Properties.Subscriber>
   </userSettings>
   <!--<system.serviceModel>