Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the source data does not even contain a "%", we can trivially determine that percent-decoding is not required. Similarly, if it does not contain a "%" or "+", we can determine that form-decoding is not required.
This cuts the time to iterate path components (which often don't contain percent-encoding) by about 30-40%, and sometimes much more -- if the source is a
String, we don't even need to copy. And it has essentially no impact on data which actually is encoded, because constructing a string from decoded contents is way more expensive than this check.Before:
After: