New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #44 PR #104

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Varadinsky
Contributor

Varadinsky commented Oct 16, 2016

Added the namespaces parmeter to as_sparql that accepts either the URI::NamespaceMap object or HASH ref that is then used to create the instance of URI::NamespaceMap inside the method.
#44

Zoran

@kasei

This comment has been minimized.

Show comment
Hide comment
@kasei

kasei Oct 26, 2016

Owner

Oh, that's interesting. The tests reveal some unintended serializations coming out of AtteanX::Serializer::SPARQL. The changes here look good, but I'm going to have to think about how to fix the serializer before I'm comfortable merging this.

Thanks!

Owner

kasei commented Oct 26, 2016

Oh, that's interesting. The tests reveal some unintended serializations coming out of AtteanX::Serializer::SPARQL. The changes here look good, but I'm going to have to think about how to fix the serializer before I'm comfortable merging this.

Thanks!

Show outdated Hide outdated lib/Attean/API/Query.pm Outdated
@Varadinsky

This comment has been minimized.

Show comment
Hide comment
@Varadinsky

Varadinsky Nov 2, 2016

Contributor

I see. No probs, let me know when you decide to merge and I will update tests.

Contributor

Varadinsky commented Nov 2, 2016

I see. No probs, let me know when you decide to merge and I will update tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment