New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cpanfile, with M::I deps #5

Merged
merged 1 commit into from Feb 3, 2016

Conversation

Projects
None yet
2 participants
@ambs
Contributor

ambs commented Feb 2, 2016

This way other deps that clone your rep can install de dependencies
on M::I using cpanm. For details see
http://blogs.perl.org/users/lestrrat/2013/03/the-main-problem-with-cpan-modules-on-github.html

@kasei

This comment has been minimized.

Show comment
Hide comment
@kasei

kasei Feb 2, 2016

Owner

Not sure I fully understand what this is doing. Should this include other things like Module::Install::AuthorTests?

Owner

kasei commented Feb 2, 2016

Not sure I fully understand what this is doing. Should this include other things like Module::Install::AuthorTests?

Add cpanfile, with M::I deps
This way other deps that clone your rep can install de dependencies
on M::I using cpanm. For details see
http://blogs.perl.org/users/lestrrat/2013/03/the-main-problem-with-cpan-modules-on-github.html
@ambs

This comment has been minimized.

Show comment
Hide comment
@ambs

ambs Feb 3, 2016

Contributor

I just fixed the cpanfile, changing the phase where it is needed (develop) and adding the module you suggest. The idea is, for someone who downloads the repo from git, can do cpanm --installdeps . and have Module::Install deps installed without needing to look to the Makefile.PL and guess the deps.

it could also list the other deps from Makefile.PL, but I didn't add them at this time, as I also did not added cpanfile to the MANIFEST.

In any case, I can change at will :)

Contributor

ambs commented Feb 3, 2016

I just fixed the cpanfile, changing the phase where it is needed (develop) and adding the module you suggest. The idea is, for someone who downloads the repo from git, can do cpanm --installdeps . and have Module::Install deps installed without needing to look to the Makefile.PL and guess the deps.

it could also list the other deps from Makefile.PL, but I didn't add them at this time, as I also did not added cpanfile to the MANIFEST.

In any case, I can change at will :)

kasei added a commit that referenced this pull request Feb 3, 2016

Merge pull request #5 from ambs/pr/cpanfile
Add cpanfile, with Module::Install deps (#5 from Alberto Simões).

@kasei kasei merged commit 0ac0556 into kasei:master Feb 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment