IRI.pm: Must specify lower bound on regex quantifiers #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 5 occurrences of /{,\d}/ in this module. I suspect these were
meant to mean {0,\d}, that is a quantifier matching 0 times up to the
specified limit. But instead Perl thinks they are trying to match a
left brace followed by a comma, followed by the digits, followed by a
right brace. Perl 5.25 now warns about this usage, and so this was
found.
It could be that I'm wrong and the code is meant to match that sequence, but it seems unlikely. And if I'm right, it indicates that there are tests missing that would have found this. (The same construct is used as well in Attean.)