Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upplotting modules from multiple samples #5
Merged
Conversation
|
Impressive!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hey @kassambara,
Here, I replicated the original plotting functions with little modification to handle the multiple samples. When possible, the data from multiple samples are overlayed on a single graph and otherwise on multiple facets (when there is more than one line in a one sample plot).
As with plotting the single file modules, the function
qc_plot_collectiondispatches on the appropriate classqc_read_collecitonand calls the internals corresponding to the input of the argumentmodules.There had to be some copy and paste involved, as I tried to keep the new code in separate files.
Thanks for taking the time to read my suggestions.