Fix for readr 1.2.0 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readr 1.2.0 automatically skips blank lines, so they are no longer included in the count of the `skip` parameter. Unfortunately this broke fastqcr.
|
Thank you for your contribution!! |
kassambara
added a commit
that referenced
this pull request
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readr 1.2.0 automatically skips blank lines, so they are no longer
included in the count of the
skipparameter. Unfortunately this brokefastqcr.
readr 1.2.0 will be submitted to CRAN soon, once it is these changes will fix fastqcr to work with the new readr version. Once readr is on CRAN you can remove the
Remotes:lines in theDESCRIPTION.Sorry for the breakage!