Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upggtheme also accepts objects of 'theme' type #11
Conversation
|
thank you for your contribution!! |
|
@kassambara Thanks for merging! Do you have any plans to push the current development version to CRAN any time soon? |
|
The plan is to submit it next week... |
|
Hi @kassambara I am guessing you couldn't submit the package to Trying to plan next release for my package accordingly. |
Minor changes
roxygen2.stylerpackage.Major changes
The function now works with
ggthemeargument of eitherfunctionorthemetype.Example
Created on 2018-08-28 by the reprex package (v0.2.0.9000).
Rationale
This was done to make it compatible with my function
ggstatsplot::ggcorrmat(https://github.com/IndrajeetPatil/ggstatsplot/blob/master/R/ggcorrmat.R), which is a wrapper aroundggcorrplot. All functions in my package have the argumentggtheme, but I force users to enter athemeand not afunctionclass object. So, out of the need for consistency across functions in a single package, I also wantedggcorrmatto behave the same way, which is possible only if the underlying function (ggcorrplot::ggcorrplot) was modified.