Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes to documentation #16

Closed
wants to merge 5 commits into from

Conversation

@IndrajeetPatil
Copy link
Contributor

@IndrajeetPatil IndrajeetPatil commented Oct 29, 2018

This PR addresses a few minor issues-

  1. In all README and roxygen examples, the argument outline.color was written as outline.col, which created warnings in RStudio scripts about the partial matching of arguments. Fixed that.
  2. The resolution of figures in README was poor and text in figures was not legible in README available on CRAN. The update fixes that using dpi of 300 and output width of 100%.
  3. It is advised not to include the date in the DESCRIPTION file (jrowen/rhandsontable#83). Removed the date accordingly (This was also creating problems for a stricter version of devtools::check()).
  4. Styled the code in tidyverse style guide (both in R script and README file).
  5. Added spelling tests to make sure no spelling error fall through the cracks.
  6. Bumped up the package version to highlight that this is the development version. Added a few more badges to README to convey the same thing.
  7. The digits argument (introduced in #12) wasn't working properly (IndrajeetPatil/ggstatsplot#93). This is now fixed. Also added an example to show that this works.
updating my version of the fork
@IndrajeetPatil
Copy link
Contributor Author

@IndrajeetPatil IndrajeetPatil commented Dec 17, 2018

Here is an example with the bug in digits argument fixed-

library(ggcorrplot)
#> Loading required package: ggplot2

# Changing number of digits for correlation coeffcient
ggcorrplot(cor(mtcars), 
           type = "lower", 
           insig = "blank", 
           lab = TRUE, 
           digits = 3)

Created on 2018-12-17 by the reprex package (v0.2.1)

kassambara added a commit that referenced this pull request May 19, 2019
kassambara added a commit that referenced this pull request May 19, 2019
@kassambara
Copy link
Owner

@kassambara kassambara commented May 19, 2019

merged thanks

@kassambara kassambara closed this May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.