Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in cohens_d for one sample t-test #22

Closed
mllewis opened this issue Jan 7, 2020 · 2 comments
Closed

bug in cohens_d for one sample t-test #22

mllewis opened this issue Jan 7, 2020 · 2 comments

Comments

@mllewis
Copy link

@mllewis mllewis commented Jan 7, 2020

For one sample t-tests, cohens_d ignores mu argument.

> ToothGrowth %>% cohens_d(len ~ 1, mu = 0) # default mu value
# A tibble: 1 x 6
  .y.   group1 group2     effsize     n magnitude
* <chr> <chr>  <chr>        <dbl> <int> <ord>    
1 len   1      null model    2.46    60 large    

> ToothGrowth %>% cohens_d(len ~ 1, mu = 5)
# A tibble: 1 x 6
  .y.   group1 group2     effsize     n magnitude
* <chr> <chr>  <chr>        <dbl> <int> <ord>    
1 len   1      null model    2.46    60 large    

> ToothGrowth %>% cohens_d(len ~ 1, mu = 10000000)
# A tibble: 1 x 6
  .y.   group1 group2     effsize     n magnitude
* <chr> <chr>  <chr>        <dbl> <int> <ord>    
1 len   1      null model    2.46    60 large
kassambara added a commit that referenced this issue Jan 7, 2020
@kassambara
Copy link
Owner

@kassambara kassambara commented Jan 7, 2020

fixed now, thanks

@mllewis
Copy link
Author

@mllewis mllewis commented Jan 8, 2020

Wonderful, thank you!

@mllewis mllewis closed this Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.