New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggtheme does not affect risk.table #1

Closed
MarcinKosinski opened this Issue Feb 10, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@MarcinKosinski
Contributor

MarcinKosinski commented Feb 10, 2016

I am testing your package, since survMisc with great survMisc:::autoplot.survfit has been removed from CRAN and I occure a funny bug that ggtheme parameter does not affect risk.table and the outputed plot looks ridiculous

library(survminer)
library(ggthemes)
ggsurvplot(survfit(Surv(times, patient.vital_status)~dataset,
                                     data = BRCAOV.survInfo),
                     #pval = TRUE, conf.int = TRUE,
                     risk.table = TRUE,
                     ggtheme = theme_bw(base_size = 24, base_family = "serif") ,
                     break.time.by = 800,
                     palette = c("#FF9E29", "#86AA00"))

survminer

I think changes should be done in those lines of ggsurvplot https://github.com/kassambara/survminer/blob/master/R/ggsurvplot.R#L338-L343

@kassambara

This comment has been minimized.

Show comment
Hide comment
@kassambara

kassambara Feb 12, 2016

Owner

This bug has been fixed in the latest version of survminer (on Github).

Thank you for your comments,
A. Kassambara

Owner

kassambara commented Feb 12, 2016

This bug has been fixed in the latest version of survminer (on Github).

Thank you for your comments,
A. Kassambara

@MarcinKosinski

This comment has been minimized.

Show comment
Hide comment
@MarcinKosinski

MarcinKosinski Feb 12, 2016

Contributor

Thanks. Looks great right now.

Contributor

MarcinKosinski commented Feb 12, 2016

Thanks. Looks great right now.

kassambara pushed a commit that referenced this issue Feb 29, 2016

kassambara pushed a commit that referenced this issue Jan 24, 2017

kassambara pushed a commit that referenced this issue Feb 2, 2017

Merge pull request #1 from kassambara/master
Merge master with MarcinKosinski::fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment