New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other tests than log-rank for testing survival curves and Log-rank test for trend #17

Closed
MarcinKosinski opened this Issue Feb 22, 2016 · 9 comments

Comments

Projects
None yet
2 participants
@MarcinKosinski
Contributor

MarcinKosinski commented Feb 22, 2016

There are more possibilities than log-rank test for comparing survival curves. One are more vulnerable for early differences and one are more vulnerable for late differences. There are few popular tests, check this : http://stats.stackexchange.com/a/172976/49793

Do you think this is possible to implement more comparing tests and allow user to specify the p-value of which test he would like to add to the survplot?

@kassambara

This comment has been minimized.

Show comment
Hide comment
@kassambara

kassambara Feb 23, 2016

Owner

I'll work on that!
Thanks!

Owner

kassambara commented Feb 23, 2016

I'll work on that!
Thanks!

@MarcinKosinski

This comment has been minimized.

Show comment
Hide comment
@MarcinKosinski

MarcinKosinski Feb 23, 2016

Contributor

You could provide p-value value and the name of used test (above the value of p-value) :)

Contributor

MarcinKosinski commented Feb 23, 2016

You could provide p-value value and the name of used test (above the value of p-value) :)

@kassambara

This comment has been minimized.

Show comment
Hide comment
@kassambara

kassambara Feb 23, 2016

Owner

Thank you in advance Marcin :-)!

Owner

kassambara commented Feb 23, 2016

Thank you in advance Marcin :-)!

@MarcinKosinski

This comment has been minimized.

Show comment
Hide comment
@MarcinKosinski

MarcinKosinski Feb 26, 2016

Contributor

Related with #15 ?

Contributor

MarcinKosinski commented Feb 26, 2016

Related with #15 ?

@kassambara

This comment has been minimized.

Show comment
Hide comment
@kassambara

kassambara Feb 26, 2016

Owner

I think that it's useful to have also the option to add logrank test for trend!

Owner

kassambara commented Feb 26, 2016

I think that it's useful to have also the option to add logrank test for trend!

@MarcinKosinski MarcinKosinski changed the title from Other tests than log-rank for testing survival curves to Other tests than log-rank for testing survival curves and Log-rank test for trend Mar 23, 2016

@MarcinKosinski

This comment has been minimized.

Show comment
Hide comment
@MarcinKosinski

MarcinKosinski Mar 23, 2016

Contributor

I've closed #15 since those topics were almost the same :)

Contributor

MarcinKosinski commented Mar 23, 2016

I've closed #15 since those topics were almost the same :)

@MarcinKosinski

This comment has been minimized.

Show comment
Hide comment
@MarcinKosinski

MarcinKosinski Jan 28, 2017

Contributor

Will update a functionality for this tomorrow

Contributor

MarcinKosinski commented Jan 28, 2017

Will update a functionality for this tomorrow

@MarcinKosinski

This comment has been minimized.

Show comment
Hide comment
@MarcinKosinski

MarcinKosinski Jan 29, 2017

Contributor

proposition for this functionality is in the #127

Contributor

MarcinKosinski commented Jan 29, 2017

proposition for this functionality is in the #127

@MarcinKosinski

This comment has been minimized.

Show comment
Hide comment
@MarcinKosinski

MarcinKosinski Apr 7, 2017

Contributor

Log-rank tests for trend moved to #188

Contributor

MarcinKosinski commented Apr 7, 2017

Log-rank tests for trend moved to #188

kassambara pushed a commit that referenced this issue Jun 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment