New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

risk.table.y.axis.text.col #8

Closed
MarcinKosinski opened this Issue Feb 15, 2016 · 6 comments

Comments

Projects
None yet
2 participants
@MarcinKosinski
Contributor

MarcinKosinski commented Feb 15, 2016

Haye you considered merging regular legend with the y.axis.text element on risk.table plot?
The the function call could like this:

ggsurvplot(fit, pval = TRUE, conf.int = TRUE, risk.table.ticks.col = TRUE,
           risk.table = TRUE, legend = "none" )

And the legend would appear vertically instead of y.axis.text element on risk.table plot OR the y.axis.text element could be coloured to the corresponding strata values?

@kassambara

This comment has been minimized.

Show comment
Hide comment
@kassambara

kassambara Feb 15, 2016

Owner

Good idea!
New argument risk.table.ticks.col added: logical value. Default value is FALSE. If TRUE, risk table tick labels will be colored by strata.

Owner

kassambara commented Feb 15, 2016

Good idea!
New argument risk.table.ticks.col added: logical value. Default value is FALSE. If TRUE, risk table tick labels will be colored by strata.

@MarcinKosinski

This comment has been minimized.

Show comment
Hide comment
@MarcinKosinski

MarcinKosinski Feb 15, 2016

Contributor

Looks great

if(!require(devtools)) install.packages("devtools")
devtools::install_github("kassambara/survminer")
#++++++++++++++++++++++++++++++++++++
require("survival")
fit<- survfit(Surv(time, status) ~ sex, data = lung)
library("survminer")
# Drawing survival curves
ggsurvplot(fit)
ggsurvplot(fit, pval = TRUE, conf.int = TRUE, risk.table.ticks.col = TRUE,
           risk.table = TRUE, legend = "none" )

Thanks!

risk_tbl_ticks_col

Contributor

MarcinKosinski commented Feb 15, 2016

Looks great

if(!require(devtools)) install.packages("devtools")
devtools::install_github("kassambara/survminer")
#++++++++++++++++++++++++++++++++++++
require("survival")
fit<- survfit(Surv(time, status) ~ sex, data = lung)
library("survminer")
# Drawing survival curves
ggsurvplot(fit)
ggsurvplot(fit, pval = TRUE, conf.int = TRUE, risk.table.ticks.col = TRUE,
           risk.table = TRUE, legend = "none" )

Thanks!

risk_tbl_ticks_col

@MarcinKosinski

This comment has been minimized.

Show comment
Hide comment
@MarcinKosinski

MarcinKosinski Feb 15, 2016

Contributor

Maybe it's better to call this 'risk.table.text.col'? What do You think?

Marcin Kosinski

Dnia 15.02.2016 o godz. 19:56 Alboukadel KASSAMBARA notifications@github.com napisał(a):

Good idea!
New argument risk.table.ticks.col added: logical value. Default value is FALSE. If TRUE, risk table tick labels will be colored by strata.


Reply to this email directly or view it on GitHub.

Contributor

MarcinKosinski commented Feb 15, 2016

Maybe it's better to call this 'risk.table.text.col'? What do You think?

Marcin Kosinski

Dnia 15.02.2016 o godz. 19:56 Alboukadel KASSAMBARA notifications@github.com napisał(a):

Good idea!
New argument risk.table.ticks.col added: logical value. Default value is FALSE. If TRUE, risk table tick labels will be colored by strata.


Reply to this email directly or view it on GitHub.

@kassambara

This comment has been minimized.

Show comment
Hide comment
@kassambara

kassambara Feb 15, 2016

Owner

Which one is most explicit among these 3 options:

  • risk.table.text.col?
  • risk.table.ytext.col?
  • risk.table.strata.col?

Thanks in advance!

Owner

kassambara commented Feb 15, 2016

Which one is most explicit among these 3 options:

  • risk.table.text.col?
  • risk.table.ytext.col?
  • risk.table.strata.col?

Thanks in advance!

@MarcinKosinski

This comment has been minimized.

Show comment
Hide comment
@MarcinKosinski

MarcinKosinski Feb 15, 2016

Contributor

I would go risk.table.y.text.col as y.text is a ggplot object in
theme() ?
No problem, it is you who are doing a favour to me :)

2016-02-15 22:21 GMT+01:00 Alboukadel KASSAMBARA notifications@github.com:

Which one is most explicit among these 3 options:

  • risk.table.text.col?
  • risk.table.ytext.col?
  • risk.table.strata.col?

Thanks in advance!


Reply to this email directly or view it on GitHub
#8 (comment).

Contributor

MarcinKosinski commented Feb 15, 2016

I would go risk.table.y.text.col as y.text is a ggplot object in
theme() ?
No problem, it is you who are doing a favour to me :)

2016-02-15 22:21 GMT+01:00 Alboukadel KASSAMBARA notifications@github.com:

Which one is most explicit among these 3 options:

  • risk.table.text.col?
  • risk.table.ytext.col?
  • risk.table.strata.col?

Thanks in advance!


Reply to this email directly or view it on GitHub
#8 (comment).

@kassambara

This comment has been minimized.

Show comment
Hide comment
@kassambara

kassambara Feb 16, 2016

Owner

risk.table.y.text.col argument can be used now.

Thanks,
A. Kassambara

Owner

kassambara commented Feb 16, 2016

risk.table.y.text.col argument can be used now.

Thanks,
A. Kassambara

kassambara pushed a commit that referenced this issue Dec 9, 2016

Merge pull request #8 from kassambara/master
merge fork:MarcinKosinski with master

kassambara pushed a commit that referenced this issue Feb 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment