Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCensor shape can be changed #186 #187
Merged
Conversation
Hint: Shape values need to be passed numerically, see http://sape.inf.usi.ch/quick-reference/ggplot2/shape "|", which is a sensible shape for censors, has the code 124.
Hint: Shape values need to be passed numerically, see http://sape.inf.usi.ch/quick-reference/ggplot2/shape "|", which is a sensible shape for censors, has the code 124.
|
Thank you for the pull request. Much appreciated! |
kassambara
added a commit
that referenced
this pull request
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Addressing #186, i have implemented a keyword argument censor.shape. This argument accepts numerical values for ggplot shapes and defaults to 3 (equivalent to the previously used "+").
Censor shape can be changed to "|" by passing censor.shape =124 (see http://sape.inf.usi.ch/quick-reference/ggplot2/shape). I have updated README.rmd, but I was unable to knit README.md due to some badges, this still needs to be done.
This is my first pull request ever, so I am not so sure if I have done everything as I should.