Skip to content

Dave Lee
kastiglione

Organizations

@facebook @ReactiveCocoa
Jun 21, 2016
@kastiglione

My feedback here was optional. I think it could work, but only saves a little bit of code so definitely not worth holding this up. 🚒🚒🚒

Jun 1, 2016
kastiglione commented on issue facebook/chisel#161
@kastiglione

Thanks for the report. I'll investigate.

Jun 1, 2016
@kastiglione

I think you could do: @weakify(self); dispatch_block_t block = ^{ @strongify(self); objc_msgSendSuper(&(struct objc_super){ self, [self superclass]…

May 23, 2016
kastiglione commented on pull request facebook/FBRetainCycleDetector#9
@kastiglione

If you don't use move it will be copy initialized, which isn't necessary, so yeah. However why is this one an rvalue reference while the strings ar…

May 20, 2016
@kastiglione

A couple comments, but looks good either way.

May 20, 2016
@kastiglione

Actually Class does not conform to <NSCopying>, but it does have a -copyWithZone: method.

May 20, 2016
@kastiglione

This loop looks like it can be made with less conditionals, thanks to objc nil messaging: while (currentClass && currentClass != previousClass) { N…

May 20, 2016
@kastiglione

Cool, I was unsure whether Class conformed to <NSCopying>.

May 20, 2016
@kastiglione

Why make it adjustable? The tests are passing NO, but does caching even effect the tests? Is there a reason someone would create a FBObjectGraphCon…

May 17, 2016
kastiglione deleted branch expression-refactor at facebook/chisel
May 16, 2016
May 16, 2016
@kastiglione
May 16, 2016
kastiglione merged pull request facebook/chisel#155
@kastiglione
Expression refactor
15 commits with 81 additions and 162 deletions
May 13, 2016
kastiglione commented on issue facebook/chisel#159
@kastiglione

Yeah seems like an obvious addition πŸ‘. Would you be interested giving it a shot?

May 13, 2016
kastiglione commented on pull request facebook/chisel#155
@kastiglione

I figure I'll merge this if there are no reviewers. cc @facebook/team-chisel-restored

May 12, 2016
@kastiglione

Thanks for the report. These errors happen when one of the ivars in an object holds a struct that uses bitfields (the b in these errors). There is …

May 12, 2016
kastiglione commented on issue facebook/chisel#124
@kastiglione

Which version of Xcode? In Xcode 7.3.0, stdio in python scripts was broken, but it's fixed in 7.3.1. In any case, it seems we know at least one maj…

May 11, 2016
kastiglione commented on issue facebook/chisel#124
@kastiglione

If anyone wants to help debug this, here's a gist that has two simple commands stdio_print and result_print: https://gist.github.com/kastiglione/c5…

May 10, 2016
kastiglione commented on pull request facebook/FBAllocationTracker#8
@kastiglione

🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒 🚒

May 10, 2016
kastiglione commented on issue facebook/chisel#124
@kastiglione

just as a datapoint, I also have a quick look command which is a python script and it does run in AppCode Thanks! I wonder if chisel should stop …

May 10, 2016
kastiglione commented on issue facebook/chisel#124
@kastiglione

has no visual effect in AppCode This sounds like a bug. I wonder if the lack of output for the logs has anything to do with the lack of output fo…

May 10, 2016
kastiglione commented on pull request facebook/chisel#143
@kastiglione

I wonder what all possible outcomes are when object is not actually an objc object. At this point, all that is known is that the memory is large en…

May 10, 2016
kastiglione commented on pull request facebook/chisel#143
@kastiglione

Another check to perform before calling the block, is to check if the object is being deallocated, presumably by calling -allowsWeakReference.

May 10, 2016
kastiglione commented on pull request facebook/chisel#143
@kastiglione

This might not work, it will have to be tested or double checked. My question is around the nature of the range values returned by the malloc syste…

May 9, 2016
@kastiglione
May 9, 2016
kastiglione merged pull request facebook/chisel#133
@kastiglione
Add two commands pproperties, pblock
16 commits with 249 additions and 53 deletions
May 9, 2016
kastiglione commented on pull request facebook/chisel#133
@kastiglione

Thanks again!

May 9, 2016
@kastiglione
May 9, 2016
kastiglione merged pull request facebook/chisel#152
@kastiglione
Add 'pbundlepath' Print application's bundle directory path
1 commit with 23 additions and 0 deletions
May 9, 2016
kastiglione commented on pull request facebook/chisel#152
@kastiglione

opened up to other contributors Chisel contributions of awesome commands, but not many contributors do refactoring. If these commands get merged,…

Something went wrong with that request. Please try again.