Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upswitched to RWMutex to avoid fully locking if only reads occur #19
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
codecov
bot
Aug 20, 2018
Codecov Report
Merging #19 into master will not change coverage.
The diff coverage is100%.
@@ Coverage Diff @@
## master #19 +/- ##
====================================
Coverage 80% 80%
====================================
Files 8 8
Lines 500 500
====================================
Hits 400 400
Misses 100 100| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/types/list/list.go | 99.04% <100%> (ø) |
|
| pkg/types/hashmap/hmap.go | 100% <100%> (ø) |
|
| pkg/types/set/set.go | 100% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update aa3ba4b...25787d7. Read the comment docs.
codecov
bot
commented
Aug 20, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
====================================
Coverage 80% 80%
====================================
Files 8 8
Lines 500 500
====================================
Hits 400 400
Misses 100 100
Continue to review full report at Codecov.
|
kasvith
assigned
BigJk
Aug 21, 2018
kasvith
added
the
accepted
label
Aug 21, 2018
kasvith
merged commit 180acc4
into
kasvith:master
Aug 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
BigJk commentedAug 20, 2018
•
edited
Pull Request for issue
#17
Description
Switch from Mutex to RWMutex. Parallel read operations shouldn't lock up the whole structure, thus a RWMutex makes more sense in this scenario to speedup reading.
Testing Instructions
Additional Comments