runtime: Support for host cgroupv2 #4397

yaoyinnan · 2022-06-06T12:47:16Z

Added support for cgroups v2 to Kata Containers so that Kata Containers will work on systems that only support cgroups v2.

Fixes: #3073

Signed-off-by: yaoyinnan yaoyinnan@foxmail.com

snir911 · 2022-06-07T09:06:03Z

Nice! Thanks! were you able to run CI jobs locally (or locally, both requires some modifications)?
Also please update the host-cgroups docs (maybe it appears in other docs as well, i didn't check).

/test
(I suppose this should be followed by some new CI jobs that uses cgruoupsv2 host at some point, but meanwhile let's see how it goes with current jobs ;) )

yaoyinnan · 2022-06-07T09:15:14Z

@snir911 OK I will revise the CI tests and docs later.

yaoyinnan · 2022-06-09T06:04:40Z

Currently the Manager of containerd/cgroups lacks the MoveTo method, I need to wait for the PR (containerd/cgroups#235) to be merged before I can update the mod.

liyimeng · 2022-07-05T11:45:46Z

@yaoyinnan Thanks for the great work, is it finally ready? would be nice to have it in 2.5.0

bergwolf

lgtm! @yaoyinnan Please rebase your PR, thanks!

bergwolf · 2022-07-07T04:02:12Z

There are a few left-overs though:

@yaoyinnan Please update docs about the change, like in docs/install/container-manager/containerd/containerd-install.md and docs/design/host-cgroups.md
Let's switch one of the exiting CI jobs to run cgroups v2 host instead. @GabyCT Is it doable? Or do you prefer to add a new job for cgroupsv2?

fidencio · 2022-07-08T14:59:11Z

This is a very nice work, indeed!
I do believe we should add a new CI job for cgroupsv2.

yaoyinnan · 2022-07-08T15:12:56Z

@liyimeng Not ready yet, still need to add a new CI job, I will do it soon.

@fidencio Yes, I will add a new CI job later.

fidencio · 2022-07-08T15:32:08Z

@liyimeng Not ready yet, still need to add a new CI job, I will do it soon.

@fidencio Yes, I will add a new CI job later.

Gaby has already a CI setup using Ubuntu 22.04, which comes with cgroupsv2 by default.
She'll make her PR depend on this one, so we should be good to go in that front.

fidencio · 2022-07-08T15:32:41Z

Reference: kata-containers/tests#4902

This PR adds the suppor for ubuntu 22.04 in order to have it in our kata CI. Fixes kata-containers#4901 Depends-on: github.com/kata-containers/kata-containers#4397 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>

GabyCT · 2022-07-08T17:19:57Z

@bergwolf and @yaoyinnan, we have a CI job that has cgroupsv2 which is Ubuntu 22.04, to trigger that CI, we just need to do /test-ubuntu22

GabyCT · 2022-07-08T17:20:50Z

I put a Depends-On on my PR (which is adding or changing packages) that will change the setup of Ubuntu to test this PR

This PR adds the suppor for ubuntu 22.04 in order to have it in our kata CI. Fixes kata-containers#4901 Depends-on: github.com/kata-containers/kata-containers#4397 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>

jodh-intel

Thanks @yaoyinnan.

lgtm

jodh-intel · 2022-07-13T12:28:58Z

src/runtime/pkg/resourcecontrol/utils_linux_test.go

@@ -106,6 +108,73 @@ func TestValidCgroupPath(t *testing.T) {

 }

+func TestValidCgroupPathV2(t *testing.T) {


liubin · 2022-07-13T13:17:14Z

/test

GabyCT · 2022-07-14T22:05:56Z

/test

GabyCT · 2022-07-14T22:06:05Z

/test-ubuntu22

Fix tests that are failing with cgroupsv2 in ubuntu 22.04. Fixes: kata-containers#4922 Depends-on: github.com/kata-containers/kata-containers#4397 Signed-off-by: yaoyinnan <yaoyinnan@foxmail.com>

fidencio · 2022-07-27T19:17:47Z

@yaoyinnan, can we remove the "wip" label and have this one merged?

Fix tests that are failing with cgroupsv2 in ubuntu 22.04. Fixes: kata-containers#4922 Depends-on: github.com/kata-containers/kata-containers#4397 Signed-off-by: yaoyinnan <yaoyinnan@foxmail.com>

Currently cgroup v2 is supported. Remove the note that host cgroup v2 is not supported. Fixes: kata-containers#3073 Signed-off-by: yaoyinnan <yaoyinnan@foxmail.com>

Support cgroup v2 on the host. Update vendor containerd/cgroups to add cgroup v2. Fixes: kata-containers#3073 Signed-off-by: yaoyinnan <yaoyinnan@foxmail.com>

liubin · 2022-07-28T03:18:27Z

/test

Fix tests that are failing with cgroupsv2 in ubuntu 22.04. Fixes: kata-containers#4922 Depends-on: github.com/kata-containers/kata-containers#4397 Signed-off-by: yaoyinnan <yaoyinnan@foxmail.com>

This PR adds the suppor for ubuntu 22.04 in order to have it in our kata CI. Fixes kata-containers#4901 Depends-on: github.com/kata-containers/kata-containers#4397 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>

This PR adds the suppor for ubuntu 22.04 in order to have it in our kata CI. Fixes kata-containers#4901 Depends-on: github.com/kata-containers/kata-containers#4397 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com> (cherry picked from commit ba1dd85)

katacontainersbot added the size/large Task of significant size label Jun 6, 2022

snir911 added no-backport-needed Changed do not need to be applied to an older branch / repository no-forward-port-needed Changed do not need to be applied to a newer branch / repository labels Jun 7, 2022

liubin added the soc Summer of Code related label Jun 9, 2022

yaoyinnan mentioned this pull request Jun 15, 2022

feat(v2): Support cgroup.MoveTo in cgroupv2 manager containerd/cgroups#235

Merged

yaoyinnan force-pushed the 3073/ftr/host-cgroupv2 branch from 95ce7f1 to 7eea8cb Compare June 24, 2022 08:40

ManaSugi mentioned this pull request Jul 5, 2022

Error while running kata containers in Ubuntu 22.04 #4583

Closed

bergwolf approved these changes Jul 7, 2022

View reviewed changes

yaoyinnan force-pushed the 3073/ftr/host-cgroupv2 branch from 7eea8cb to 86c04db Compare July 8, 2022 11:26

yaoyinnan requested a review from a team as a code owner July 8, 2022 11:26

yaoyinnan force-pushed the 3073/ftr/host-cgroupv2 branch 3 times, most recently from 9a617bf to 093e6f1 Compare July 8, 2022 13:56

yaoyinnan force-pushed the 3073/ftr/host-cgroupv2 branch from 093e6f1 to 404d0ab Compare July 8, 2022 15:30

GabyCT mentioned this pull request Jul 8, 2022

ci: Add support for ubuntu 22.04 kata-containers/tests#4902

Merged

yaoyinnan force-pushed the 3073/ftr/host-cgroupv2 branch from 06299db to 16edb10 Compare July 13, 2022 03:48

jodh-intel approved these changes Jul 13, 2022

View reviewed changes

yaoyinnan force-pushed the 3073/ftr/host-cgroupv2 branch from 16edb10 to e2adb5e Compare July 14, 2022 07:41

yaoyinnan mentioned this pull request Jul 15, 2022

ci: Fix tests that are failing with cgroupsv2 kata-containers/tests#4938

Merged

yaoyinnan added 2 commits July 28, 2022 10:30

docs: Update support for host cgroupv2

4ab45e5

Currently cgroup v2 is supported. Remove the note that host cgroup v2 is not supported. Fixes: kata-containers#3073 Signed-off-by: yaoyinnan <yaoyinnan@foxmail.com>

runtime: Support for host cgroup v2

5c3155f

Support cgroup v2 on the host. Update vendor containerd/cgroups to add cgroup v2. Fixes: kata-containers#3073 Signed-off-by: yaoyinnan <yaoyinnan@foxmail.com>

yaoyinnan force-pushed the 3073/ftr/host-cgroupv2 branch from e2adb5e to 5c3155f Compare July 28, 2022 02:31

liubin removed the wip Work in Progress (PR incomplete - needs more work or rework) label Jul 28, 2022

liubin merged commit a67402c into kata-containers:main Jul 28, 2022

yaoyinnan mentioned this pull request Aug 11, 2022

vmm process was incorrectly added to kata_sandbox cgroup in cgroup v2 #4886

Open

fidencio mentioned this pull request Aug 31, 2022

stable-2.5 | ci: Add support for ubuntu 22.04 kata-containers/tests#5093

Closed

yaoyinnan mentioned this pull request Oct 21, 2022

runtime-rs: cgroup v2 support #5491

Open

This was referenced Feb 10, 2023

kata-manager: Fails on cgroupsv2 only systems (Fedora) #6259

Closed

Support host side cgroups v2 #927

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

runtime: Support for host cgroupv2 #4397

runtime: Support for host cgroupv2 #4397

yaoyinnan commented Jun 6, 2022

snir911 commented Jun 7, 2022

yaoyinnan commented Jun 7, 2022

yaoyinnan commented Jun 9, 2022

liyimeng commented Jul 5, 2022 •

edited

bergwolf left a comment

bergwolf commented Jul 7, 2022

fidencio commented Jul 8, 2022

yaoyinnan commented Jul 8, 2022

fidencio commented Jul 8, 2022

fidencio commented Jul 8, 2022

GabyCT commented Jul 8, 2022

GabyCT commented Jul 8, 2022

jodh-intel left a comment

jodh-intel Jul 13, 2022

liubin commented Jul 13, 2022

GabyCT commented Jul 14, 2022

GabyCT commented Jul 14, 2022

fidencio commented Jul 27, 2022

liubin commented Jul 28, 2022

		@@ -106,6 +108,73 @@ func TestValidCgroupPath(t *testing.T) {

		}

		func TestValidCgroupPathV2(t *testing.T) {

runtime: Support for host cgroupv2 #4397

runtime: Support for host cgroupv2 #4397

Conversation

yaoyinnan commented Jun 6, 2022

snir911 commented Jun 7, 2022

yaoyinnan commented Jun 7, 2022

yaoyinnan commented Jun 9, 2022

liyimeng commented Jul 5, 2022 • edited

bergwolf left a comment

Choose a reason for hiding this comment

bergwolf commented Jul 7, 2022

fidencio commented Jul 8, 2022

yaoyinnan commented Jul 8, 2022

fidencio commented Jul 8, 2022

fidencio commented Jul 8, 2022

GabyCT commented Jul 8, 2022

GabyCT commented Jul 8, 2022

jodh-intel left a comment

Choose a reason for hiding this comment

jodh-intel Jul 13, 2022

Choose a reason for hiding this comment

liubin commented Jul 13, 2022

GabyCT commented Jul 14, 2022

GabyCT commented Jul 14, 2022

fidencio commented Jul 27, 2022

liubin commented Jul 28, 2022

liyimeng commented Jul 5, 2022 •

edited