runtime: using threaded mode to manage cgroupv2 #5153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaoyinnan
changed the title
yaoyinnan
force-pushed
the
4886/fix/cgroupv2-threaded-mode
branch
2 times, most recently
from
0d7a4e3
to
a2bd465
Compare
|
It seems that containerd/cgroups doesn't support macOS very well. |
liubin
reviewed
Sep 13, 2022
liubin
reviewed
Sep 13, 2022
liubin
reviewed
Sep 13, 2022
yaoyinnan
force-pushed
the
4886/fix/cgroupv2-threaded-mode
branch
8 times, most recently
from
02830ed
to
3033e53
Compare
Yes, it looks like this repo doesn't support macOS. The containerd/cgroups#55 also mentioned this situation. |
katacontainersbot
added
size/large
yaoyinnan
force-pushed
the
4886/fix/cgroupv2-threaded-mode
branch
3 times, most recently
from
29f109a
to
f681471
Compare
|
/test |
yaoyinnan
force-pushed
the
4886/fix/cgroupv2-threaded-mode
branch
2 times, most recently
from
9158df6
to
9c9d89a
Compare
liubin
reviewed
Sep 16, 2022
yaoyinnan
force-pushed
the
4886/fix/cgroupv2-threaded-mode
branch
3 times, most recently
from
f6765f9
to
c01013d
Compare
|
/test-fedora |
|
/test-s390x |
Closed
yaoyinnan
force-pushed
the
4886/fix/cgroupv2-threaded-mode
branch
from
c6d19b4
to
eb1ead3
Compare
|
/test |
|
@bergwolf @jodh-intel @fidencio @snir911 This PR has basically been completed. Can you review and push to approve this PR for me? |
yaoyinnan
added
the
area/runtime
yaoyinnan
force-pushed
the
4886/fix/cgroupv2-threaded-mode
branch
from
eb1ead3
to
0730c0b
Compare
katacontainersbot
added
size/huge
yaoyinnan
force-pushed
the
4886/fix/cgroupv2-threaded-mode
branch
from
0730c0b
to
c0e2a17
Compare
|
/test |
yaoyinnan
force-pushed
the
4886/fix/cgroupv2-threaded-mode
branch
2 times, most recently
from
682c784
to
e291eea
Compare
katacontainersbot
added
size/large
yaoyinnan
force-pushed
the
4886/fix/cgroupv2-threaded-mode
branch
2 times, most recently
from
199224e
to
5f52358
Compare
yaoyinnan
changed the title
yaoyinnan
force-pushed
the
4886/fix/cgroupv2-threaded-mode
branch
from
5f52358
to
83c82dd
Compare
Update the description that threaded mode for management in cgroupv2 in host cgroups docs Fixes: kata-containers#4886 Signed-off-by: yaoyinnan <35447132+yaoyinnan@users.noreply.github.com>
Because cgroups linux has modified the interface, the cgroups darwin interface has been unified. Fixes: kata-containers#4886 Signed-off-by: yaoyinnan <35447132+yaoyinnan@users.noreply.github.com>
The sandbox and overhead are placed in the same cgroup through threaded mode. Fixes: kata-containers#4886 Signed-off-by: yaoyinnan <35447132+yaoyinnan@users.noreply.github.com>
For different versions of cgroups, use different methods to delete cgroups. For cgroup v2, you need to delete the thread mode cgroup first. Fixes: kata-containers#4886 Signed-off-by: yaoyinnan <35447132+yaoyinnan@users.noreply.github.com>
Retry delete and moveto operations to ensure cgroup resource recycling. Fixes: kata-containers#4886 Signed-off-by: yaoyinnan <35447132+yaoyinnan@users.noreply.github.com>
yaoyinnan
force-pushed
the
4886/fix/cgroupv2-threaded-mode
branch
from
83c82dd
to
e629db1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current cgroupv2, because the process mode cannot separate processes and threads into different cgroups, the vmm process is incorrectly added to the sandbox cgroup. The sandbox and overhead are placed in the same cgroup through thread mode to realize that the vCPU thread is placed in the sandbox and other processes are placed in the overhead.
Fixes: #4886
Signed-off-by: yaoyinnan yaoyinnan@foxmail.com