kata-sys-util: fix issues where umount2 couldn't get the correct path #5873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
justxuewei
force-pushed
the
fix/umount2
branch
from
d8398e9
to
47a9afc
Compare
justxuewei
force-pushed
the
fix/umount2
branch
from
47a9afc
to
c8dfd13
Compare
justxuewei
force-pushed
the
fix/umount2
branch
from
c8dfd13
to
cc7aecd
Compare
justxuewei
changed the title
|
/test |
Strings in Rust don't have \0 at the end, but C does, which leads to `umount2` in the libc can't get the correct path. Besides, calling `nix::mount::umount2` to avoid using an unsafe block is a robust solution. Fixes: kata-containers#5871 Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
justxuewei
force-pushed
the
fix/umount2
branch
from
cc7aecd
to
8079a97
Compare
lifupan
approved these changes
Dec 12, 2022
|
/test |
|
/retest |
|
/test-ubuntu-metrics |
1 similar comment
|
/test-ubuntu-metrics |
lifupan
added
no-backport-needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strings in Rust don't have \0 at the end, but C does, which leads to
umount2in the libc can't get the correct path. Besides, calling
nix::mount::umount2to avoid using an unsafe block is a robust solution.
Fixes: #5871
Signed-off-by: Xuewei Niu niuxuewei.nxw@antgroup.com