clh: Support VFIO device unplug #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cloud-hypervisor commit `6d30fe05` introduced a fix on its API for VFIO device hotplug (`VmAddDevice`), which is required for supporting VFIO unplug through openAPI calls in kata. Signed-off-by: Bo Chen <chen.bo@intel.com>
We can rely on the error handling of the actual HTTP API calls to catch errors, and don't need to call VmmPing explicitly in advance. Signed-off-by: Bo Chen <chen.bo@intel.com>
|
/test-clh |
likebreath
changed the title
This patch adds the support of VFIO device unplug when using cloud-hypervisor. Fixes: kata-containers#860 Signed-off-by: Bo Chen <chen.bo@intel.com>
|
/test-ubuntu |
jodh-intel
approved these changes
Oct 6, 2020
| _, err := cl.VmRemoveDevicePut(ctx, chclient.VmRemoveDevice{Id: device.ID}) | ||
|
|
||
| if err != nil { | ||
| err = fmt.Errorf("failed to hotplug remove vfio device %+v %s", device, openAPIClientError(err)) |
There was a problem hiding this comment.
Nit: I'd consider adding a colon just before the original error:
Suggested change
| err = fmt.Errorf("failed to hotplug remove vfio device %+v %s", device, openAPIClientError(err)) | |
| err = fmt.Errorf("failed to hotplug remove vfio device %+v: %s", device, openAPIClientError(err)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port PR kata-containers/runtime#2996 for issue kata-containers/runtime#2569.
This patch adds the support of VFIO device unplug when using
cloud-hypervisor.
Fixes: #860
Signed-off-by: Bo Chen chen.bo@intel.com