This repository has been archived by the owner on May 12, 2021. It is now read-only.
Allow to override build date with SOURCE_DATE_EPOCH #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OOh, reproducible... I know @jodh-intel has mentioned that for builds since, well, forever! ;-) |
bmwiedemann
added a commit
to bmwiedemann/osbuilder
that referenced
this pull request
Aug 8, 2019
Allow to override build date with SOURCE_DATE_EPOCH in order to make builds reproducible. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. Also use UTC to be independent of timezone. This date call only works with GNU date. Without this patch, kata-containers-initrd.img contained varying var/lib/osbuilder/osbuilder.yaml with version: "1.9.0-alpha0" -rootfs-creation-time: "2019-08-06T18:40:27.402493939+0000Z" +rootfs-creation-time: "2034-09-08T07:57:34.386990704+0000Z" Fixes kata-containers#340 Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
devimc
reviewed
Aug 8, 2019
Allow to override build date with SOURCE_DATE_EPOCH in order to make builds reproducible. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. Also use UTC to be independent of timezone. This date call only works with GNU date. Without this patch, kata-containers-initrd.img contained varying var/lib/osbuilder/osbuilder.yaml with version: "1.9.0-alpha0" -rootfs-creation-time: "2019-08-06T18:40:27.402493939+0000Z" +rootfs-creation-time: "2034-09-08T07:57:34.386990704+0000Z" Fixes kata-containers#340 Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
devimc
approved these changes
Aug 8, 2019
GabyCT
approved these changes
Aug 8, 2019
|
/test |
Merged
devimc
approved these changes
Aug 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Allow to override build date with
SOURCE_DATE_EPOCHin order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.
Also use UTC to be independent of timezone.
Note: This date call only works with GNU date.
Without this patch,
kata-containers-initrd.imgcontained a varyingvar/lib/osbuilder/osbuilder.yamlwithThis PR was done while working on reproducible builds for openSUSE.