Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bmwiedemann!!
To keep our CI happy, please could you add a Signed-off-by: comment in your commit (see https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#general-format).
007f418
to
2714815
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much @bmwiedemann!
lgtm
|
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
CI is failing with: /cc @devimc - this seems to be an intermittent failure. |
|
@jodh-intel yes, and I think the problem is in the agent, I'm thinking that 1 second is not enough time to wait for new vCPUs in nested environments, see https://github.com/kata-containers/agent/blob/master/grpc.go#L69-L71 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just a comment about timestamp.
|
@bmwiedemann this is great, thank you. Does this completely address reproducible builds for linux-container ? |
|
@egernst it does for the binaries in the rpm. For fully bit-identical rpm packages, there would need to be a And then it would be possible that if you add more variations like Debian (varying build-path, umask, timezone, locale) then you could get variations in binaries again. |
to make kata-linux-container package builds reproducible. See https://reproducible-builds.org/ for why this is good. Uses -u to be independent of timezone. Uses LANG=C to not have Day-of-Week and Month names vary. Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
|
Nice - thanks @bmwiedemann. /retest |
|
18.04 CI fell over with: /retest as I can't see this PR would cause that... |
Override build user+host+timestamp
to make kata-linux-container package builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of the variable.
SOURCE_DATE_EPOCHis unset atm in the .spec file case because no changelog is there to allow rpm to parse the date from it.Fixes part of issue #394
This PR was done while working on reproducible builds for openSUSE.