Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
kata-deploy: add k3s support #823
By default, k3s uses an embedded containerd. Reconfiguring this
Signed-off-by: Brandon Wilson firstname.lastname@example.org
As noted in rancher/k3s#274, you can already configure k3s to instead use an external cri currently supported by kata-deploy.
jodh-intel left a comment
Thanks @wilsonianb and great news!
lgtm but please squash your two commits together into a single commit ("
egernst left a comment •
The changes are clean, and look fine for enabling K3S.
Stepping back, I begin to get concerned that kata-deploy is going to get bigger, and bigger. ie, I'm looking at similar changes that'll be necessary for minikube (/cc @tstromberg).
If we add support, we should make sure that we have a way to test this in our CI as well.
egernst left a comment
Thinking through it more - I'm hoping to simplify things, and perhaps push more of the changes in a k3s specific yaml, rather than making larger changes in bash.
PTAL and let me know what you think?
By default, k3s uses an embedded containerd. Reconfiguring this containerd requires modifying a template config file and restarting the k3s (master node) or k3s-agent (worker node) systemd service. Signed-off-by: Brandon Wilson <email@example.com>