This repository has been archived by the owner on May 12, 2021. It is now read-only.
firecracker: Add support for default VM configuration #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcastelino
force-pushed
the
topic/fc_cpu_mem
branch
from
7111f04
to
b7fb0f4
Compare
sboeuf
reviewed
May 2, 2019
There was a problem hiding this comment.
Two nits, but the code looks good! Thanks @mcastelino for tackling this :)
virtcontainers/fc.go
Outdated
| @@ -351,6 +373,10 @@ func (fc *firecracker) startSandbox(timeout int) error { | |||
| return err | |||
| } | |||
|
|
|||
| fc.fcSetVMBaseConfig(int64(fc.config.MemorySize), | |||
grahamwhaley
approved these changes
May 2, 2019
There was a problem hiding this comment.
lgtm, given @sboeuf feedback.
Do we need any docs updates to go with this, or is it 'obvious that this is how it should work' ?
|
holding off a \ t e s t and merge until we hear back from @mcastelino |
mcastelino
force-pushed
the
topic/fc_cpu_mem
branch
from
b7fb0f4
to
c5509ea
Compare
Kata support specifing the default VM configuration via configuration.toml. This allows the system or cluster admin to choose the default (i.e minimum) size of the VM. Add support in kata to respect the VM configuration for firecracker. Also refactor some code to make error handling uniform. Fixes: kata-containers#1594 Signed-off-by: Manohar Castelino <manohar.r.castelino@intel.com>
mcastelino
force-pushed
the
topic/fc_cpu_mem
branch
from
c5509ea
to
b496f3f
Compare
egernst
approved these changes
May 2, 2019
sboeuf
approved these changes
May 2, 2019
|
/test |
egernst
approved these changes
May 2, 2019
|
Fedora job failed due to: kata-containers/tests#1449 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
firecracker: Add support for default VM configuration
Kata support specifing the default VM configuration via configuration.toml. This allows the system or cluster admin to choose the default (i.e minimum) size of the VM.
Add support in kata to respect the VM configuration for firecracker.
Fixes: #1594
Signed-off-by: Manohar Castelino manohar.r.castelino@intel.com