cli: add systemd-cgroup option #747
Conversation
|
PSS Measurement: Memory inside container: |
devimc
force-pushed
the
topic/systemdCgroup
branch
from
5f1d9d2
to
57b8c3c
Compare
|
PSS Measurement: Memory inside container: |
devimc
force-pushed
the
topic/systemdCgroup
branch
from
57b8c3c
to
01d359b
Compare
|
PSS Measurement: Memory inside container: |
Add support for cgroup driver systemd. systemd cgroup is not applied in the VM since in some cases like initrd images there is no systemd running and nobody can update a systemd cgroup using systemctl. fixes kata-containers#596 Signed-off-by: Julio Montes <julio.montes@intel.com>
devimc
force-pushed
the
topic/systemdCgroup
branch
from
01d359b
to
0075175
Compare
|
PSS Measurement: Memory inside container: |
Codecov Report
@@ Coverage Diff @@
## master #747 +/- ##
==========================================
+ Coverage 65.41% 65.43% +0.02%
==========================================
Files 87 87
Lines 10532 10541 +9
==========================================
+ Hits 6889 6897 +8
- Misses 2951 2952 +1
Partials 692 692 |
| // - Initrd image doesn't have systemd. | ||
| // - Nobody will be able to modify the resources of a specific container by using systemctl set-property. | ||
| // - docker is not running in the VM. | ||
| if systemdCgroup { |
There was a problem hiding this comment.
I wonder if we can do the conversion in the cli package instead?
There was a problem hiding this comment.
I thought the same, the problem is that systemd cgroup should be applied in the host (if systemd is the init process and where docker is running), so I prefer to modify the grpcSpec before sending it to the agent and don't modify the original ociSpec to let virtcontainer apply it in the host
There was a problem hiding this comment.
hmm, sound good to me. Thanks @devimc .
|
I'm adding host cgroup support currently: #734 Wondering if this should also apply to host cgroup? When user/docker specify systemd cgroup, which layer do they want to apply? Host Cgroup or Guest Cgroup? |
Systemd cgroup should be applied in the host, not in the guest
|
|
@devimc Oh, I mis-read your description, this is good to me. I'll take this into consideration while doing host cgroup support, but this depends on the flag provided by your PR. LGTM |
…tdin agent: don't receive signals from stdin
Add support for cgroup driver systemd.
systemd cgroup is not applied in the VM since in some cases like initrd images
there is no systemd running and nobody can update a systemd cgroup using
systemctl.
fixes #596
Signed-off-by: Julio Montes julio.montes@intel.com