Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1399 [BUG]Can't set file server in subdomain with request path is "/" #1400

Merged
merged 5 commits into from Dec 13, 2019

Conversation

@minhvh93
Copy link
Contributor

minhvh93 commented Dec 2, 2019

We'd love to see more contributions

Read how you can contribute to the project.

Please attach an issue link which your PR solves otherwise your work may be rejected.

kataras and others added 2 commits Nov 22, 2019
@minhvh93 minhvh93 requested a review from kataras as a code owner Dec 2, 2019
@claassistantio

This comment has been minimized.

Copy link

claassistantio commented Dec 2, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

minhvh93
kataras
minhvh


minhvh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kataras kataras added this to the v12.1.0 milestone Dec 12, 2019
Copy link
Owner

kataras left a comment

LGTM and tested yesterday. Will be merged soon and it will be part of the upcoming 12.1.0 release.

kataras added a commit that referenced this pull request Dec 13, 2019
@kataras kataras merged commit 4928213 into kataras:master Dec 13, 2019
1 of 2 checks passed
1 of 2 checks passed
license/cla Contributor License Agreement is not signed yet.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.